Bug 124227

Summary: [CSS Shapes] Accept the new <box> value for shape-outside
Product: WebKit Reporter: Bear Travis <betravis>
Component: CSSAssignee: Bear Travis <betravis>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, eflews.bot, esprehn+autocc, giles_joplin, glenn, gyuyoung.kim, kondapallykalyan, macpherson, menard, syoichi
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 124173    
Attachments:
Description Flags
Initial patch
none
Updated patch
none
Adding parsing tests and fixme none

Bear Travis
Reported 2013-11-12 13:20:36 PST
http://dev.w3.org/csswg/css-shapes/#shape-outside-property adds the values [margin/border/padding/content]-box as valid values for shape properties.
Attachments
Initial patch (29.71 KB, patch)
2013-11-13 13:29 PST, Bear Travis 		no flags
DetailsFormatted DiffDiff
Updated patch (30.19 KB, patch)
2013-11-13 15:20 PST, Bear Travis 		no flags
DetailsFormatted DiffDiff
Adding parsing tests and fixme (35.43 KB, patch)
2013-11-14 10:50 PST, Bear Travis 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Bear Travis
Comment 1 2013-11-13 13:29:25 PST
Created attachment 216849 [details] Initial patch
EFL EWS Bot
Comment 2 2013-11-13 13:47:44 PST
Comment on attachment 216849 [details] Initial patch Attachment 216849 [details] did not pass efl-ews (efl): Output: http://webkit-queues.appspot.com/results/22869161
EFL EWS Bot
Comment 3 2013-11-13 14:02:20 PST
Comment on attachment 216849 [details] Initial patch Attachment 216849 [details] did not pass efl-wk2-ews (efl-wk2): Output: http://webkit-queues.appspot.com/results/22780010
Bear Travis
Comment 4 2013-11-13 15:20:01 PST
Created attachment 216872 [details] Updated patch
Hans Muller
Comment 5 2013-11-14 09:43:49 PST
Shouldn't this patch include new parsing tests in fast/shapes/parsing/?
Hans Muller
Comment 6 2013-11-14 09:52:30 PST
> m_shape = Shape::createShape(m_shapeLogicalSize, LayoutSize(), writingMode, margin, padding); This appears to be a stub, since the border radii have been punted. Might be a good place for a FIXME, see https://bugs.webkit.org/show_bug.cgi?id=124368
Bear Travis
Comment 7 2013-11-14 10:50:25 PST
Created attachment 216961 [details] Adding parsing tests and fixme
Dave Hyatt
Comment 8 2013-11-14 12:56:31 PST
Comment on attachment 216961 [details] Adding parsing tests and fixme r=me
WebKit Commit Bot
Comment 9 2013-11-14 13:24:41 PST
Comment on attachment 216961 [details] Adding parsing tests and fixme Clearing flags on attachment: 216961 Committed r159307: <http://trac.webkit.org/changeset/159307>
WebKit Commit Bot
Comment 10 2013-11-14 13:24:45 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.