Bug 124646

Summary:

[armv7][arm64] Build is likely to fail since r159545

Product:

WebKit

Reporter:

Julien Brianceau <jbriance>

Component:

JavaScriptCore

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, fpizlo, ossy, rgabor, sam, zherczeg

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

108645

Attachments:

Description	Flags
Rename memfence to memoryFence in ARMv7 and ARM64 macro assembler.	none
Rename memfence to memoryFence in ARMv7 and ARM64 macro assembler (2).	none
Rename memfence to memoryFence in ARMv7 and ARM64 macro assembler and fix missing OP_DMB_SY_T2b.	none

Julien Brianceau

Reported 2013-11-20 01:46:05 PST

Build is likely to fail since http://trac.webkit.org/changeset/159545 for ARMv7 and ARM64 architectures. "memfence" should be renamed "memoryFence" in Macro Assembler.

Attachments
Rename memfence to memoryFence in ARMv7 and ARM64 macro assembler. (1.57 KB, patch) 2013-11-20 01:50 PST, Julien Brianceau	no flags	Details Formatted Diff Diff
Rename memfence to memoryFence in ARMv7 and ARM64 macro assembler (2). (1.57 KB, patch) 2013-11-20 01:52 PST, Julien Brianceau	no flags	Details Formatted Diff Diff
Rename memfence to memoryFence in ARMv7 and ARM64 macro assembler and fix missing OP_DMB_SY_T2b. (2.15 KB, patch) 2013-11-20 02:37 PST, Julien Brianceau	no flags	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Julien Brianceau

Comment 1 2013-11-20 01:50:53 PST

Created attachment 217407 [details] Rename memfence to memoryFence in ARMv7 and ARM64 macro assembler.

Julien Brianceau

Comment 2 2013-11-20 01:52:21 PST

Created attachment 217408 [details] Rename memfence to memoryFence in ARMv7 and ARM64 macro assembler (2).

Julien Brianceau

Comment 3 2013-11-20 02:37:50 PST

Created attachment 217411 [details] Rename memfence to memoryFence in ARMv7 and ARM64 macro assembler and fix missing OP_DMB_SY_T2b. I also think that one of the two "OP_DMB_SY_T2a" should be "OP_DMB_SY_T2b".

WebKit Commit Bot

Comment 4 2013-11-20 08:00:21 PST

Comment on attachment 217411 [details] Rename memfence to memoryFence in ARMv7 and ARM64 macro assembler and fix missing OP_DMB_SY_T2b. Clearing flags on attachment: 217411 Committed r159564: <http://trac.webkit.org/changeset/159564>

WebKit Commit Bot

Comment 5 2013-11-20 08:00:25 PST

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.