Bug 125396

Summary: [CSS Grid Layout] Do log(n) search in the named line vectors when positioning named line spans
Product: WebKit Reporter: Ryosuke Niwa <rniwa>
Component: Layout and RenderingAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, commit-queue, dino, esprehn+autocc, glenn, hyatt, kling, kondapallykalyan, llango.u-szeged, rego, rniwa, simon.fraser, xan.lopez
Priority: P2 Keywords: BlinkMergeCandidate
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 133304    
Attachments:
Description Flags
Patch none

Ryosuke Niwa
Reported 2013-12-07 13:14:44 PST
Consider merging https://chromium.googlesource.com/chromium/blink/+/9fc477af0be708c490a6b90e65e412b0c22b161f Implement the suggested FIXMEs and do a log search in the named line vectors. This maintains the previous (somewhat tricky) behavior by using std::lower_bound and std::upper_bound. No difference in existing performance tests, but should scale much better for big grids.
Attachments
Patch (4.01 KB, patch)
2013-12-10 04:28 PST, László Langó 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
László Langó
Comment 1 2013-12-10 04:28:01 PST
Created attachment 218852 [details] Patch
Andreas Kling
Comment 2 2014-01-30 23:35:48 PST
Comment on attachment 218852 [details] Patch OK
WebKit Commit Bot
Comment 3 2014-01-31 00:05:30 PST
Comment on attachment 218852 [details] Patch Clearing flags on attachment: 218852 Committed r163166: <http://trac.webkit.org/changeset/163166>
WebKit Commit Bot
Comment 4 2014-01-31 00:05:34 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.