Bug 126327

Summary: Use getc rather than getbyte on older ruby
Product: WebKit Reporter: Jeremy Huddleston Sequoia <jeremyhu>
Component: JavaScriptCoreAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: fpizlo, mcatanzaro, ossy
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
URL: http://trac.macports.org/ticket/37740
Bug Depends on:    
Bug Blocks: 126492    
Attachments:
Description Flags
patch to check ruby version first none

Jeremy Huddleston Sequoia
Reported 2013-12-30 21:29:41 PST
Created attachment 220146 [details] patch to check ruby version first You should use getc on older ruby (or update configure to abort if ruby is older than 1.8.7) Trivial patch attached.
Attachments
patch to check ruby version first (500 bytes, patch)
2013-12-30 21:29 PST, Jeremy Huddleston Sequoia 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Csaba Osztrogonác
Comment 1 2014-01-13 06:01:03 PST
Please add changelog and set r? if you would like to ask review.
Filip Pizlo
Comment 2 2014-01-13 11:05:37 PST
Comment on attachment 220146 [details] patch to check ruby version first This looks fine. Can you prepare-ChangeLog and resubmit the patch? I'll be happy to r+ with appropriate ChangeLog text.
Csaba Osztrogonác
Comment 3 2014-02-06 08:12:37 PST
ping
Filip Pizlo
Comment 4 2014-02-06 10:21:01 PST
(In reply to comment #3) > ping Do you want to do the honors and land this with a changelog? R=me.
Michael Catanzaro
Comment 5 2015-05-10 14:07:57 PDT
Looks like 1.8.7 is the minimum required nowadays, so closing.
Note You need to log in before you can comment on or make changes to this bug.