Bug 126886

Summary: [CSS Regions] Hit-testing goes through clipped layer in fast/regions/overflow-first-and-last-regions-in-container-hidden.html
Product: WebKit Reporter: Andrei Bucur <abucur>
Component: WebCore Misc.Assignee: Andrei Bucur <abucur>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, esprehn+autocc, glenn, kondapallykalyan, simon.fraser, WebkitBugTracker
Priority: P2 Keywords: AdobeTracked
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 116295    
Attachments:
Description Flags
Patch
none
Patch none

Andrei Bucur
Reported 2014-01-13 06:33:39 PST
If you move the cursor above the orange rectangles (that clip) of the left side tests of fast/regions/overflow-first-and-last-regions-in-container-hidden.html, the cursor changes to a text selection icon. This means the text inside the regions that was clipped out actually is detected by the hit-test algorithm.
Attachments
Patch (7.75 KB, patch)
2014-01-13 10:14 PST, Andrei Bucur 		no flags
DetailsFormatted DiffDiff
Patch (7.65 KB, patch)
2014-01-15 00:42 PST, Andrei Bucur 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Andrei Bucur
Comment 1 2014-01-13 10:14:36 PST
Created attachment 221060 [details] Patch
Mihnea Ovidenie
Comment 2 2014-01-14 07:14:10 PST
Comment on attachment 221060 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=221060&action=review r=me with some comments > Source/WebCore/ChangeLog:10 > + flow thread. The patch verifies the location is inside the clipping rectangle of the region before "the location" - > "that the location" > Source/WebCore/rendering/RenderLayer.cpp:7015 > + ClipRectsContext clipRectsContext(rootLayer, hitTestLocation.region(), TemporaryClipRects, IgnoreOverlayScrollbarSize); You do not need to specify the last param - IgnoreOverlayScrollbarSize - as it is the default value in ctor. > LayoutTests/fast/regions/hover-and-js-in-visual-overflow-hidden.html:80 > + <li>Move the mouse under the gray rectangle.</li> "under" -> "below". I found under confusing in this context.
Andrei Bucur
Comment 3 2014-01-15 00:42:35 PST
Created attachment 221236 [details] Patch
Mihnea Ovidenie
Comment 4 2014-01-15 01:06:52 PST
Comment on attachment 221236 [details] Patch r=me
WebKit Commit Bot
Comment 5 2014-01-15 02:26:07 PST
Comment on attachment 221236 [details] Patch Clearing flags on attachment: 221236 Committed r162064: <http://trac.webkit.org/changeset/162064>
WebKit Commit Bot
Comment 6 2014-01-15 02:26:09 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.