Bug 127200

Summary: [CSS Shapes] Preserve box-shape order when serializing shape values
Product: WebKit Reporter: Bear Travis <betravis>
Component: CSSAssignee: Bear Travis <betravis>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, dino, dstockwell, esprehn+autocc, glenn, gyuyoung.kim, kondapallykalyan, macpherson, menard, simon.fraser
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 124173    
Attachments:
Description Flags
Initial Patch
none
Factoring code common to shapes and clipping
none
Swapping boolean for CSSPropertyID none

Bear Travis
Reported 2014-01-17 15:40:07 PST
The shape-outside value 'content-box circle()' should serialize as 'content-box circle()' rather than 'circle() content-box'. This is only true for non-computed styles, as the computed style places the box after the shape.
Attachments
Initial Patch (21.43 KB, patch)
2014-01-17 16:05 PST, Bear Travis 		no flags
DetailsFormatted DiffDiff
Factoring code common to shapes and clipping (25.81 KB, patch)
2014-01-20 13:40 PST, Bear Travis 		no flags
DetailsFormatted DiffDiff
Swapping boolean for CSSPropertyID (25.82 KB, patch)
2014-01-21 13:11 PST, Bear Travis 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Bear Travis
Comment 1 2014-01-17 16:05:20 PST
Created attachment 221505 [details] Initial Patch
Bear Travis
Comment 2 2014-01-20 13:40:27 PST
Created attachment 221688 [details] Factoring code common to shapes and clipping
Dirk Schulze
Comment 3 2014-01-21 01:54:07 PST
Comment on attachment 221688 [details] Factoring code common to shapes and clipping View in context: https://bugs.webkit.org/attachment.cgi?id=221688&action=review Patch looks great! Just some smaller snippets. > Source/WebCore/css/CSSParser.cpp:5862 > +PassRefPtr<CSSValue> CSSParser::parseBasicShapeAndOrBox(bool allowBoundingBox) Could you make that a static function or inline function please? Could you replace the boolean with a CSSPropertyID and check the id instead? That makes understanding the code easier. > Source/WebCore/css/CSSParser.h:182 > + PassRefPtr<CSSValue> parseBasicShapeAndOrBox(bool allowBoundingBox); See comment above
Bear Travis
Comment 4 2014-01-21 13:11:05 PST
Created attachment 221780 [details] Swapping boolean for CSSPropertyID
Dirk Schulze
Comment 5 2014-01-21 13:38:18 PST
Comment on attachment 221780 [details] Swapping boolean for CSSPropertyID r=me
WebKit Commit Bot
Comment 6 2014-01-21 14:19:31 PST
Comment on attachment 221780 [details] Swapping boolean for CSSPropertyID Clearing flags on attachment: 221780 Committed r162475: <http://trac.webkit.org/changeset/162475>
WebKit Commit Bot
Comment 7 2014-01-21 14:19:34 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.