Bug 128795

Summary:

FTL should inline polymorphic heap accesses

Product:

WebKit

Reporter:

Filip Pizlo <fpizlo>

Component:

JavaScriptCore

Assignee:

Filip Pizlo <fpizlo>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

barraclough, benjamin, buildbot, bunhere, cmarcelo, commit-queue, ggaren, gyuyoung.kim, jeremyckahn, mark.lam, mhahnenberg, mmirman, msaboff, nrotem, oliver, rakuco, rniwa, sam, sergio

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Bug Depends on:

128796, 128864, 128899

Bug Blocks:

112840

Attachments:

Description	Flags
work in progress	none
work in progress	none
it ran things	none
the patch	buildbot: commit-queue-
Archive of layout-test-results from webkit-ews-10 for mac-mountainlion-wk2	none
the patch	none
the patch	none
the patch	oliver: review+

Filip Pizlo

Reported 2014-02-13 19:45:45 PST

Patch forthcoming.

Attachments
work in progress (15.45 KB, patch) 2014-02-13 19:46 PST, Filip Pizlo	no flags	Details Formatted Diff Diff
work in progress (40.63 KB, patch) 2014-02-13 22:26 PST, Filip Pizlo	no flags	Details Formatted Diff Diff
it ran things (64.91 KB, patch) 2014-02-13 23:48 PST, Filip Pizlo	no flags	Details Formatted Diff Diff
the patch (62.53 KB, patch) 2014-02-14 20:55 PST, Filip Pizlo	buildbot: commit-queue-	Details Formatted Diff Diff
Archive of layout-test-results from webkit-ews-10 for mac-mountainlion-wk2 (478.12 KB, application/zip) 2014-02-15 01:09 PST, Build Bot	no flags	Details
the patch (92.20 KB, patch) 2014-02-15 18:54 PST, Filip Pizlo	no flags	Details Formatted Diff Diff
the patch (92.17 KB, patch) 2014-02-15 18:59 PST, Filip Pizlo	no flags	Details Formatted Diff Diff
the patch (92.15 KB, patch) 2014-02-15 19:26 PST, Filip Pizlo	oliver: review+	Details Formatted Diff Diff
Show Obsolete (7) View All Add attachment proposed patch, testcase, etc.

Filip Pizlo

Comment 1 2014-02-13 19:46:17 PST

Created attachment 224149 [details] work in progress

Filip Pizlo

Comment 2 2014-02-13 22:26:58 PST

Created attachment 224162 [details] work in progress

Filip Pizlo

Comment 3 2014-02-13 23:48:31 PST

Created attachment 224168 [details] it ran things

Filip Pizlo

Comment 4 2014-02-13 23:49:00 PST

Comment on attachment 224168 [details] it ran things Calling it "the patch" might be overconfident.

WebKit Commit Bot

Comment 5 2014-02-14 06:59:06 PST

Attachment 224168 [details] did not pass style-queue: ERROR: Source/JavaScriptCore/bytecode/GetByIdStatus.h:48: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] ERROR: Source/JavaScriptCore/bytecode/GetByIdStatus.h:49: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] ERROR: Source/JavaScriptCore/bytecode/GetByIdStatus.h:50: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] ERROR: Source/JavaScriptCore/bytecode/GetByIdStatus.h:51: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] ERROR: Source/JavaScriptCore/ftl/FTLLowerDFGToLLVM.cpp:3111: One line control clauses should not use braces. [whitespace/braces] [4] ERROR: Source/JavaScriptCore/dfg/DFGConstantFoldingPhase.cpp:407: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] ERROR: Source/JavaScriptCore/dfg/DFGConstantFoldingPhase.cpp:426: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] ERROR: Source/JavaScriptCore/dfg/DFGConstantFoldingPhase.cpp:430: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] ERROR: Source/JavaScriptCore/dfg/DFGConstantFoldingPhase.cpp:439: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] Total errors found: 9 in 32 files If any of these errors are false positives, please file a bug against check-webkit-style.

Filip Pizlo

Comment 6 2014-02-14 20:55:38 PST

Created attachment 224283 [details] the patch Note that this has a strong dependency on https://bugs.webkit.org/show_bug.cgi?id=128864. It'll probably crash every test on EWS.

WebKit Commit Bot

Comment 7 2014-02-14 20:56:41 PST

Attachment 224283 [details] did not pass style-queue: ERROR: Source/JavaScriptCore/bytecode/GetByIdStatus.h:48: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] ERROR: Source/JavaScriptCore/bytecode/GetByIdStatus.h:49: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] ERROR: Source/JavaScriptCore/bytecode/GetByIdStatus.h:50: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] ERROR: Source/JavaScriptCore/bytecode/GetByIdStatus.h:51: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] ERROR: Source/JavaScriptCore/bytecode/GetByIdStatus.h:131: Should have a space between // and comment [whitespace/comments] [4] ERROR: Source/JavaScriptCore/ftl/FTLLowerDFGToLLVM.cpp:3111: One line control clauses should not use braces. [whitespace/braces] [4] ERROR: Source/JavaScriptCore/dfg/DFGConstantFoldingPhase.cpp:407: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] ERROR: Source/JavaScriptCore/dfg/DFGConstantFoldingPhase.cpp:426: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] ERROR: Source/JavaScriptCore/dfg/DFGConstantFoldingPhase.cpp:430: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] ERROR: Source/JavaScriptCore/dfg/DFGConstantFoldingPhase.cpp:439: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] Total errors found: 10 in 28 files If any of these errors are false positives, please file a bug against check-webkit-style.

Build Bot

Comment 8 2014-02-15 01:09:16 PST

Comment on attachment 224283 [details] the patch Attachment 224283 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/5530863127232512 New failing tests: css3/viewport-percentage-lengths/css3-viewport-percentage-lengths-getStyle.html editing/inserting/insert-composition-whitespace.html css3/compositing/background-blend-mode-property-parsing.html cssom/cssvalue-comparison.html compositing/overflow/automatically-opt-into-composited-scrolling.html accessibility/canvas-fallback-content-2.html css3/flexbox/box-sizing.html accessibility/canvas-fallback-content.html css3/filters/filter-property-parsing.html editing/execCommand/enabling-and-selection.html css3/flexbox/align-absolute-child.html css3/compositing/blend-mode-property-parsing.html editing/execCommand/enabling-and-selection-2.html css3/filters/filter-property-computed-style.html css3/filters/offscreen-filters-memory-usage.html animations/animation-direction-reverse-hardware.html canvas/philip/tests/2d.imageData.put.unchanged.html editing/pasteboard/4076267-3.html css3/filters/filter-property-parsing-invalid.html css3/flexbox/auto-height-dynamic.html http/tests/loading/slow-parsing-subframe.html http/tests/css/shared-stylesheet-mutation-preconstruct.html css3/flexbox/columns-auto-size.html css3/unicode-bidi-isolate-basic.html css3/zoom-coords.xhtml http/tests/css/shared-stylesheet-mutation.html http/tests/misc/acid3.html editing/deleting/5206311-2.html editing/deleting/delete-4038408-fix.html css3/flexbox/box-sizing-min-max-sizes.html

Build Bot

Comment 9 2014-02-15 01:09:21 PST

Created attachment 224291 [details] Archive of layout-test-results from webkit-ews-10 for mac-mountainlion-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: webkit-ews-10 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.5

Filip Pizlo

Comment 10 2014-02-15 18:54:46 PST

Created attachment 224305 [details] the patch

WebKit Commit Bot

Comment 11 2014-02-15 18:56:29 PST

Attachment 224305 [details] did not pass style-queue: ERROR: Source/JavaScriptCore/bytecode/GetByIdVariant.h:45: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] ERROR: Source/JavaScriptCore/bytecode/GetByIdVariant.h:46: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] ERROR: Source/JavaScriptCore/bytecode/GetByIdVariant.h:47: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] ERROR: Source/JavaScriptCore/bytecode/GetByIdVariant.h:48: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] ERROR: Source/JavaScriptCore/bytecode/GetByIdStatus.h:92: Should have a space between // and comment [whitespace/comments] [4] ERROR: Source/JavaScriptCore/ftl/FTLLowerDFGToLLVM.cpp:3111: One line control clauses should not use braces. [whitespace/braces] [4] ERROR: Source/JavaScriptCore/dfg/DFGConstantFoldingPhase.cpp:407: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] ERROR: Source/JavaScriptCore/dfg/DFGConstantFoldingPhase.cpp:426: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] ERROR: Source/JavaScriptCore/dfg/DFGConstantFoldingPhase.cpp:430: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] ERROR: Source/JavaScriptCore/dfg/DFGConstantFoldingPhase.cpp:439: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] Total errors found: 10 in 49 files If any of these errors are false positives, please file a bug against check-webkit-style.

Filip Pizlo

Comment 12 2014-02-15 18:58:25 PST

(In reply to comment #11) > Attachment 224305 [details] did not pass style-queue: > > > ERROR: Source/JavaScriptCore/bytecode/GetByIdVariant.h:45: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] > ERROR: Source/JavaScriptCore/bytecode/GetByIdVariant.h:46: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] > ERROR: Source/JavaScriptCore/bytecode/GetByIdVariant.h:47: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] > ERROR: Source/JavaScriptCore/bytecode/GetByIdVariant.h:48: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] No. > ERROR: Source/JavaScriptCore/bytecode/GetByIdStatus.h:92: Should have a space between // and comment [whitespace/comments] [4] Ooops, fixed. > ERROR: Source/JavaScriptCore/ftl/FTLLowerDFGToLLVM.cpp:3111: One line control clauses should not use braces. [whitespace/braces] [4] Fixed. > ERROR: Source/JavaScriptCore/dfg/DFGConstantFoldingPhase.cpp:407: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] > ERROR: Source/JavaScriptCore/dfg/DFGConstantFoldingPhase.cpp:426: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] > ERROR: Source/JavaScriptCore/dfg/DFGConstantFoldingPhase.cpp:430: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] > ERROR: Source/JavaScriptCore/dfg/DFGConstantFoldingPhase.cpp:439: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] Fixed. > Total errors found: 10 in 49 files > > > If any of these errors are false positives, please file a bug against check-webkit-style.

Filip Pizlo

Comment 13 2014-02-15 18:59:39 PST

Created attachment 224306 [details] the patch

WebKit Commit Bot

Comment 14 2014-02-15 19:01:20 PST

Attachment 224306 [details] did not pass style-queue: ERROR: Source/JavaScriptCore/bytecode/GetByIdVariant.h:45: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] ERROR: Source/JavaScriptCore/bytecode/GetByIdVariant.h:46: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] ERROR: Source/JavaScriptCore/bytecode/GetByIdVariant.h:47: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] ERROR: Source/JavaScriptCore/bytecode/GetByIdVariant.h:48: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] Total errors found: 4 in 49 files If any of these errors are false positives, please file a bug against check-webkit-style.

Filip Pizlo

Comment 15 2014-02-15 19:26:34 PST

Created attachment 224310 [details] the patch

WebKit Commit Bot

Comment 16 2014-02-15 19:27:33 PST

Attachment 224310 [details] did not pass style-queue: ERROR: Source/JavaScriptCore/dfg/DFGCommon.h:31: Bad include order. Mixing system and custom headers. [build/include_order] [4] ERROR: Source/JavaScriptCore/bytecode/GetByIdVariant.h:45: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] ERROR: Source/JavaScriptCore/bytecode/GetByIdVariant.h:46: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] ERROR: Source/JavaScriptCore/bytecode/GetByIdVariant.h:47: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] ERROR: Source/JavaScriptCore/bytecode/GetByIdVariant.h:48: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] Total errors found: 5 in 49 files If any of these errors are false positives, please file a bug against check-webkit-style.

Filip Pizlo

Comment 17 2014-02-16 22:30:42 PST

Landed in http://trac.webkit.org/changeset/164207

Brian Burg

Comment 18 2014-12-15 21:05:42 PST

*** Bug 66314 has been marked as a duplicate of this bug. ***

Note You need to log in before you can comment on or make changes to this bug.