Bug 129442

Summary: Updating some WebRTC and MediaStream LayoutTests
Product: WebKit Reporter: Thiago de Barros Lacerda <thiago.lacerda>
Component: Tools / TestsAssignee: Thiago de Barros Lacerda <thiago.lacerda>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, eric.carlson, glenn, hta, jer.noble, philipj, sergio, tommyw
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 124288    
Attachments:
Description Flags
Patch
none
Changes in ChangeLog
none
Changes in ChangeLog none

Thiago de Barros Lacerda
Reported 2014-02-27 12:45:44 PST
Due to changes in JavaScriptCore (in r163562), some LayoutTests in fast/mediastream needed to be updated.
Attachments
Patch (13.30 KB, patch)
2014-02-27 12:50 PST, Thiago de Barros Lacerda 		no flags
DetailsFormatted DiffDiff
Changes in ChangeLog (13.72 KB, patch)
2014-02-28 06:07 PST, Thiago de Barros Lacerda 		no flags
DetailsFormatted DiffDiff
Changes in ChangeLog (13.72 KB, patch)
2014-02-28 08:25 PST, Thiago de Barros Lacerda 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Thiago de Barros Lacerda
Comment 1 2014-02-27 12:50:23 PST
Created attachment 225402 [details] Patch
Eric Carlson
Comment 2 2014-02-27 14:50:09 PST
Comment on attachment 225402 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=225402&action=review > LayoutTests/fast/mediastream/RTCIceCandidate.html:-25 > - shouldNotThrow('initializer = JSON.parse(JSON.stringify(candidate));'); > - > - shouldNotThrow('candidate = new RTCIceCandidate(initializer);'); > - shouldBe('candidate.candidate', '"foo"'); > - shouldBe('candidate.sdpMid', '"bar"'); > - shouldBe('candidate.sdpMLineIndex', '6'); > - ChangeLog should mention why this test was changed. > LayoutTests/fast/mediastream/RTCSessionDescription.html:-24 > - shouldNotThrow('initializer = JSON.parse(JSON.stringify(sessionDescription));'); > - > - shouldNotThrow("sessionDescription = new RTCSessionDescription(initializer);"); > - shouldBe('sessionDescription.type', '"offer"'); > - shouldBe('sessionDescription.sdp', '"foobar"'); > - Ditto.
Thiago de Barros Lacerda
Comment 3 2014-02-28 06:07:41 PST
Created attachment 225456 [details] Changes in ChangeLog
Thiago de Barros Lacerda
Comment 4 2014-02-28 08:25:41 PST
Created attachment 225469 [details] Changes in ChangeLog
Eric Carlson
Comment 5 2014-02-28 12:30:07 PST
Comment on attachment 225469 [details] Changes in ChangeLog Thanks for the update!
WebKit Commit Bot
Comment 6 2014-03-02 07:31:16 PST
Comment on attachment 225469 [details] Changes in ChangeLog Clearing flags on attachment: 225469 Committed r164941: <http://trac.webkit.org/changeset/164941>
Note You need to log in before you can comment on or make changes to this bug.