Bug 129637

Summary: [GTK] Give the WebKit GObject DOM bindings API break detection it's own buildbot bubble
Product: WebKit Reporter: Martin Robinson <mrobinson>
Component: Tools / TestsAssignee: Martin Robinson <mrobinson>
Status: RESOLVED FIXED    
Severity: Normal CC: cgarcia, commit-queue
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 129571    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Return a warning when there is new API
none
Patch none

Martin Robinson
Reported 2014-03-03 16:37:18 PST
Carlos requested this in 129571.
Attachments
Patch (2.91 KB, patch)
2014-03-03 17:11 PST, Martin Robinson 		no flags
DetailsFormatted DiffDiff
Return a warning when there is new API (2.96 KB, patch)
2014-03-04 10:01 PST, Martin Robinson 		no flags
DetailsFormatted DiffDiff
Patch (6.19 KB, patch)
2014-03-04 11:36 PST, Martin Robinson 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Martin Robinson
Comment 1 2014-03-03 17:11:42 PST
Created attachment 225719 [details] Patch
Carlos Garcia Campos
Comment 2 2014-03-04 09:50:00 PST
Comment on attachment 225719 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=225719&action=review Thanks! > Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg:663 > + def evaluateCommand(self, cmd): > + if self.missingAPI: > + return FAILURE > + return SUCCESS I think we can return WARNINGS in case of compatible api changes, so that I won't miss them :-)
Martin Robinson
Comment 3 2014-03-04 10:01:58 PST
Created attachment 225786 [details] Return a warning when there is new API
Martin Robinson
Comment 4 2014-03-04 11:36:47 PST
Created attachment 225798 [details] Patch
WebKit Commit Bot
Comment 5 2014-03-04 11:37:59 PST
Attachment 225798 [details] did not pass style-queue: ERROR: Tools/BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:384: expected 2 blank lines, found 1 [pep8/E302] [5] ERROR: Tools/BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:387: [RunGtkWebKitGObjectDOMBindingsAPIBreakTestsTest.assertResults] Undefined variable 'SUCCESS' [pylint/E0602] [5] ERROR: Tools/BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:389: [RunGtkWebKitGObjectDOMBindingsAPIBreakTestsTest.assertResults] Undefined variable 'WARNINGS' [pylint/E0602] [5] ERROR: Tools/BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:391: [RunGtkWebKitGObjectDOMBindingsAPIBreakTestsTest.assertResults] Undefined variable 'FAILURE' [pylint/E0602] [5] ERROR: Tools/BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:394: [RunGtkWebKitGObjectDOMBindingsAPIBreakTestsTest.assertResults] Undefined variable 'RunGtkWebKitGObjectDOMBindingsAPIBreakTests' [pylint/E0602] [5] Total errors found: 5 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style.
Martin Robinson
Comment 6 2014-03-04 11:50:23 PST
(In reply to comment #5) > > If any of these errors are false positives, please file a bug against check-webkit-style. The style errors all look like false positives. The tests run fine for me.
Carlos Garcia Campos
Comment 7 2014-03-04 23:41:05 PST
Comment on attachment 225798 [details] Patch I guess it's the same patch, simply adding unit tests
Martin Robinson
Comment 8 2014-03-05 07:42:45 PST
Comment on attachment 225798 [details] Patch Clearing flags on attachment: 225798 Committed r165108: <http://trac.webkit.org/changeset/165108>
Martin Robinson
Comment 9 2014-03-05 07:42:47 PST
All reviewed patches have been landed. Closing bug.
Carlos Garcia Campos
Comment 10 2014-03-06 00:21:17 PST
Was there anything wrong with this patch? I don't see the new step in the bots, should we reopen this? or am I missing something?
Martin Robinson
Comment 11 2014-03-06 06:03:42 PST
I was hoping that the bots would detect the change to master.cfg and reload, but I guess they did not. Today I'll try to figure out what we need to do to have the bubble show up.
Note You need to log in before you can comment on or make changes to this bug.