Bug 13003

Summary: [S60] Plugin Window shouldn't cover the scroll bars.
Product: WebKit Reporter: Hong Zhao <hong.a.zhao>
Component: Plug-insAssignee: Nobody <webkit-unassigned>
Status: CLOSED FIXED    
Severity: Normal CC: S60webkit
Priority: P2 Keywords: PlatformOnly
Version: 523.x (Safari 3)   
Hardware: S60 Emulator   
OS: S60 3rd edition   
Attachments:
Description Flags
Recalculate clipRect based on the plugin object rect and the Browser frame rect, then passed it for pluginWin to display.
yongjun.zhang: review-
Use mainframe frameRect and plugin object rect to calculate the plugin window's clip rect.
yongjun.zhang: review+
Fix the bug of pluginwin overlap on the browser sroll bars when it's oversize in 3.2 yongjun.zhang: review+

Hong Zhao
Reported 2007-03-07 11:41:25 PST
TSW ID: HZHO-6YZR4X Plugin Window should pass a correct clip rect (without covering scroll bars). The different plugins should change their codes as well if they don't take clipRect for display.
Attachments
Recalculate clipRect based on the plugin object rect and the Browser frame rect, then passed it for pluginWin to display. (3.38 KB, patch)
2007-03-07 12:26 PST, Hong Zhao 		yongjun.zhang: review-
DetailsFormatted DiffDiff
Use mainframe frameRect and plugin object rect to calculate the plugin window's clip rect. (3.51 KB, patch)
2007-03-07 14:38 PST, Hong Zhao 		yongjun.zhang: review+
DetailsFormatted DiffDiff
Fix the bug of pluginwin overlap on the browser sroll bars when it's oversize in 3.2 (4.53 KB, patch)
2007-03-09 08:00 PST, Hong Zhao 		yongjun.zhang: review+
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Hong Zhao
Comment 1 2007-03-07 12:26:12 PST
Created attachment 13521 [details] Recalculate clipRect based on the plugin object rect and the Browser frame rect, then passed it for pluginWin to display.
Yongjun Zhang
Comment 2 2007-03-07 13:28:06 PST
Comment on attachment 13521 [details] Recalculate clipRect based on the plugin object rect and the Browser frame rect, then passed it for pluginWin to display. Frame()->FrameRect() is not the main frame rect when the page has multiple frames. The patch won't work when plugin is in a subframe.
Hong Zhao
Comment 3 2007-03-07 14:38:31 PST
Created attachment 13530 [details] Use mainframe frameRect and plugin object rect to calculate the plugin window's clip rect.
Yongjun Zhang
Comment 4 2007-03-08 07:40:42 PST
Comment on attachment 13530 [details] Use mainframe frameRect and plugin object rect to calculate the plugin window's clip rect. r=me
Hong Zhao
Comment 5 2007-03-09 08:00:12 PST
Created attachment 13558 [details] Fix the bug of pluginwin overlap on the browser sroll bars when it's oversize in 3.2
Yongjun Zhang
Comment 6 2007-03-09 10:51:16 PST
Comment on attachment 13558 [details] Fix the bug of pluginwin overlap on the browser sroll bars when it's oversize in 3.2 r=me
Bradley Morrison
Comment 7 2007-03-12 08:45:27 PDT
(In reply to comment #4) > (From update of attachment 13530 [details] [edit]) > r=me > landed on trunk - r20116
Bradley Morrison
Comment 8 2007-03-12 08:48:50 PDT
(In reply to comment #6) > (From update of attachment 13558 [details] [edit]) > r=me > Does this patch need to go into 3.1? It's not clear if this patch is targetted at 3.1. If so, it won't apply cleanly - the patch needs to be re-created.
Bradley Morrison
Comment 9 2007-03-12 09:05:38 PDT
resoved
Hong Zhao
Comment 10 2007-03-12 11:47:32 PDT
Please submit the 3rd patch. Thanks!
Bradley Morrison
Comment 11 2007-03-12 12:01:05 PDT
(In reply to comment #10) > Please submit the 3rd patch. Thanks! > r20119. In future, please combine your fixes into one patch and obsolete earlier, outdated patches.
Bradley Morrison
Comment 12 2008-04-09 11:39:48 PDT
Bulk closing of all s60 platform bugs. Sorry for the noise!
Joel Parks
Comment 13 2011-03-21 11:53:14 PDT
re-purposing InTSW keyword for use by QtWebkit team
Note You need to log in before you can comment on or make changes to this bug.