Bug 130629
| Summary: | Would like the style bot to prohibit #include layering violations | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Geoffrey Garen <ggaren> |
| Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> |
| Status: | NEW | ||
| Severity: | Normal | CC: | ossy, simon.fraser, zan |
| Priority: | P2 | Keywords: | InRadar |
| Version: | 528+ (Nightly build) | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Geoffrey Garen
Some #includes are obvious layering violations.
For example, no file in WebCore/platform should ever #include any WebCore file outside WebCore/platform.
It would be nice to codify this in a simple script.
See, for a motivating example, https://bugs.webkit.org/show_bug.cgi?id=130275.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Geoffrey Garen
<rdar://problem/16393051>
Zan Dobersek
Should we start generating separate forwarding headers for the platform layer?
Cross-inclusion of <Platform/Header.h> in WebCore would be allowed at first, but it would extremely simplify locating these layering violations.
Zan Dobersek
(In reply to comment #2)
> Cross-inclusion of <Platform/Header.h> in WebCore would be allowed at first, but it would extremely simplify locating these layering violations.
I meant the other way around, that is including <WebCore/Header.h> in the platform layer.
Csaba Osztrogonác
In my opinion if we could get rid include paths (as blink did it),
it's obvious to catch layering violations by anybody without any
sophisticated script and style checker. But unfortunately there were
many objections against relative includes to Source.
Alexey Proskuryakov
*** Bug 252858 has been marked as a duplicate of this bug. ***