Bug 130644

Summary: Call linking slow paths should be passed a CallLinkInfo* directly so that you can create a call IC without adding it to any CodeBlocks
Product: WebKit Reporter: Filip Pizlo <fpizlo>
Component: JavaScriptCoreAssignee: Filip Pizlo <fpizlo>
Status: RESOLVED FIXED    
Severity: Normal CC: barraclough, ggaren, mark.lam, mhahnenberg, msaboff, nrotem, oliver, ossy, sam, simon.fraser
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on: 130670    
Bug Blocks: 129589    
Attachments:
Description Flags
less than half way there
none
it builds on 64-bit
none
starting to work on 64-bit x86
none
the patch kling: review+

Filip Pizlo
Reported 2014-03-22 13:00:56 PDT
Patch forthcoming.
Attachments
less than half way there (37.69 KB, patch)
2014-03-22 13:01 PDT, Filip Pizlo 		no flags
DetailsFormatted DiffDiff
it builds on 64-bit (56.78 KB, patch)
2014-03-22 14:35 PDT, Filip Pizlo 		no flags
DetailsFormatted DiffDiff
starting to work on 64-bit x86 (61.30 KB, patch)
2014-03-22 15:45 PDT, Filip Pizlo 		no flags
DetailsFormatted DiffDiff
the patch (68.71 KB, patch)
2014-03-22 20:06 PDT, Filip Pizlo 		kling: review+
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Filip Pizlo
Comment 1 2014-03-22 13:01:43 PDT
Created attachment 227564 [details] less than half way there
Filip Pizlo
Comment 2 2014-03-22 14:35:24 PDT
Created attachment 227574 [details] it builds on 64-bit It even appears to pass testapi, but I'm sure it has many, many bugs.
Filip Pizlo
Comment 3 2014-03-22 15:45:56 PDT
Created attachment 227576 [details] starting to work on 64-bit x86
Filip Pizlo
Comment 4 2014-03-22 20:06:05 PDT
Created attachment 227595 [details] the patch
Andreas Kling
Comment 5 2014-03-22 21:26:19 PDT
Comment on attachment 227595 [details] the patch r=me I'd suggest using "auto" instead of Bag<T>::iterator, since you seem to like short lines. ;)
Filip Pizlo
Comment 6 2014-03-22 21:35:10 PDT
(In reply to comment #5) > (From update of attachment 227595 [details]) > r=me > > I'd suggest using "auto" instead of Bag<T>::iterator, since you seem to like short lines. ;) I did it!
Filip Pizlo
Comment 7 2014-03-22 21:35:34 PDT
Landed in http://trac.webkit.org/changeset/166135
Simon Fraser (smfr)
Comment 8 2014-03-23 09:49:54 PDT
This broke the CLOOP build.
Csaba Osztrogonác
Comment 9 2014-03-24 08:30:11 PDT
(In reply to comment #8) > This broke the CLOOP build. new bug report for fixing the build: https://bugs.webkit.org/show_bug.cgi?id=130670
Note You need to log in before you can comment on or make changes to this bug.