Bug 133317

Created attachment 232142 [details] Patch

Attachment 232142 [details] did not pass style-queue: ERROR: Source/WebCore/ChangeLog:1: ChangeLog entry has no bug number [changelog/bugnumber] [5] ERROR: ChangeLog:1: ChangeLog entry has no bug number [changelog/bugnumber] [5] Total errors found: 2 in 5 files If any of these errors are false positives, please file a bug against check-webkit-style.

(In reply to comment #2) > Attachment 232142 [details] did not pass style-queue: > > > ERROR: Source/WebCore/ChangeLog:1: ChangeLog entry has no bug number [changelog/bugnumber] [5] > ERROR: ChangeLog:1: ChangeLog entry has no bug number [changelog/bugnumber] [5] > Total errors found: 2 in 5 files > The bug was created during patch upload using '--open-bug'. This doesn't seem neither a 'style-check' bug nor a 'webkit-patch' bug, so I don't really know what to do other than upload a new patch with the bug URL updated, which is unfortunate :(

Created attachment 232185 [details] Patch

CMake itself has had a FindGnuTLS.cmake since version 2.8.0, doesn't that one work for your purposes?

(In reply to comment #5) > CMake itself has had a FindGnuTLS.cmake since version 2.8.0, doesn't that one work for your purposes? That works for me, I was unaware of that. Will update the patch removing that. Thank you.

Created attachment 232202 [details] Patch

Comment on attachment 232202 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=232202&action=review It doesn't look like ENABLE_SUBTLE_CRYPTO listed in WebKitFeatures.cmake yet or cmakeconfig.h.cmake yet? > Source/WebCore/PlatformGTK.cmake:727 > +if (ENABLE_SUBTLE_CRYPTO) > + list(APPEND WebCore_INCLUDE_DIRECTORIES > + ${GNUTLS_INCLUDE_DIRS} > + ) > + list(APPEND WebCore_LIBRARIES > + ${GNUTLS_LIBRARIES} > + ) You don't need to make this conditional. If you don't look for the package these will be empty.

(In reply to comment #8) > > It doesn't look like ENABLE_SUBTLE_CRYPTO listed in WebKitFeatures.cmake yet or cmakeconfig.h.cmake yet? > Right, ENABLE_SUBTLE_CRYPTO is added in a previous patch of this serie, for bug 133316, which is also pending review. > > Source/WebCore/PlatformGTK.cmake:727 > > +if (ENABLE_SUBTLE_CRYPTO) > > + list(APPEND WebCore_INCLUDE_DIRECTORIES > > + ${GNUTLS_INCLUDE_DIRS} > > + ) > > + list(APPEND WebCore_LIBRARIES > > + ${GNUTLS_LIBRARIES} > > + ) > > You don't need to make this conditional. If you don't look for the package these will be empty. Ok, though the conditional is also introduced in patch for bug 133316. Perhaps I should not have separated this patch from the other. To avoid these issues, I'm making this bug depend on bug 133316. After that is fixed I will update this patch accordingly. Thank you.

Created attachment 236360 [details] Patch

Comment on attachment 236360 [details] Patch LGTM, thanks!

Comment on attachment 236360 [details] Patch Clearing flags on attachment: 236360 Committed r172393: <http://trac.webkit.org/changeset/172393>

All reviewed patches have been landed. Closing bug.

Re-opened since this is blocked by bug 135796

Finally a decision was made to upgrade GnuTLS version to 3.x (gnutls28-dev) in the release and test bots. It is done now so I will re-submit the previous patch.

Created attachment 236388 [details] Patch

Comment on attachment 236388 [details] Patch Clearing flags on attachment: 236388 Committed r172433: <http://trac.webkit.org/changeset/172433>

All reviewed patches have been landed. Closing bug.

(In reply to comment #15) > Finally a decision was made to upgrade GnuTLS version to 3.x (gnutls28-dev) in the release and test bots. It is done now so I will re-submit the previous patch. But the build is still brokene due to missing GnuTLS on the following bots: - GTK Linux 32-bit Release - GTK Linux ARM Release

and all tests fail on the GTK performance bot with the following error: /home/slave/webkitgtk/gtk-linux-64-release-perf-tests/build/WebKitBuild/Release/bin/WebKitTestRunner: error while loading shared libraries: libgnutls-deb0.so.28: cannot open shared object file: No such file or directory

Yes, apparently build bots were not all upgraded. We are rushing to fix that.

(In reply to comment #21) > Yes, apparently build bots were not all upgraded. We are rushing to fix that. buildbots are happy now, bot the EWS is still failing