Bug 134340

Summary:

curl: Improve errors by including the domain

Product:

WebKit

Reporter:

cand <cand>

Component:

Platform

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Minor

CC:

basuke, buildbot, bunhere, cdumez, commit-queue, galpeter, gyuyoung.kim, rniwa, sergio

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Bug Depends on:

Bug Blocks:

117300

Attachments:

Description	Flags
Improve curl resourceerrors	buildbot: commit-queue-
Archive of layout-test-results from webkit-ews-11 for mac-mountainlion-wk2	none
Patch	achristensen: review-, buildbot: commit-queue-
Archive of layout-test-results from ews105 for mac-elcapitan-wk2	none
Patch	none
Patch	none

cand

Reported 2014-06-26 00:34:27 PDT

The domain field in ResourceError was empty before this. Fill it properly.

Attachments
Improve curl resourceerrors (1.71 KB, patch) 2014-06-26 00:35 PDT, cand	buildbot: commit-queue-	Details Formatted Diff Diff
Archive of layout-test-results from webkit-ews-11 for mac-mountainlion-wk2 (623.58 KB, application/zip) 2014-06-26 01:40 PDT, Build Bot	no flags	Details
Patch (2.98 KB, patch) 2017-02-23 16:26 PST, Basuke Suzuki	achristensen: review- buildbot: commit-queue-	Details Formatted Diff Diff
Archive of layout-test-results from ews105 for mac-elcapitan-wk2 (1.29 MB, application/zip) 2017-02-23 17:16 PST, Build Bot	no flags	Details
Patch (2.43 KB, patch) 2017-02-24 12:12 PST, Basuke Suzuki	no flags	Details Formatted Diff Diff
Patch (2.48 KB, patch) 2017-02-24 14:32 PST, Basuke Suzuki	no flags	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

cand

Comment 1 2014-06-26 00:35:21 PDT

Created attachment 233890 [details] Improve curl resourceerrors

Build Bot

Comment 2 2014-06-26 01:40:13 PDT

Comment on attachment 233890 [details] Improve curl resourceerrors Attachment 233890 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/5540800146440192 New failing tests: media/W3C/video/src/src_reflects_attribute_not_source_elements.html

Build Bot

Comment 3 2014-06-26 01:40:16 PDT

Created attachment 233894 [details] Archive of layout-test-results from webkit-ews-11 for mac-mountainlion-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: webkit-ews-11 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.5

Peter Gal

Comment 4 2014-07-01 01:01:49 PDT

Comment on attachment 233890 [details] Improve curl resourceerrors View in context: https://bugs.webkit.org/attachment.cgi?id=233890&action=review This patch doesn't have a changelog. Also please mark patches with r? to be reviewed. > Source/WebCore/platform/network/curl/ResourceHandleManager.cpp:703 > + URL tmpurl(URL(), url); The tmpurl name is not really descriptive, maybe currentUrl? > Source/WebCore/platform/network/curl/ResourceHandleManager.cpp:928 > + URL tmpurl(URL(), handle->m_url); ditto.

Basuke Suzuki

Comment 5 2017-02-23 16:26:30 PST

Created attachment 302606 [details] Patch Added error domain as "CurlErrorDomain" for ResourceErrors created while curl handling. With the conversation with Alex on the #webkit, it should be the string indicating the source of the error, not the domain name of the connection. Url information is passed explicitly in anyway.

Build Bot

Comment 6 2017-02-23 17:16:03 PST

Comment on attachment 302606 [details] Patch Attachment 302606 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/3181933 New failing tests: media/modern-media-controls/volume-down-support/volume-down-support.html

Build Bot

Comment 7 2017-02-23 17:16:07 PST

Created attachment 302614 [details] Archive of layout-test-results from ews105 for mac-elcapitan-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews105 Port: mac-elcapitan-wk2 Platform: Mac OS X 10.11.6

Alex Christensen

Comment 8 2017-02-24 01:00:25 PST

Comment on attachment 302606 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=302606&action=review > Source/WebCore/platform/network/curl/ResourceHandleManager.cpp:723 > + ResourceError resourceError(AtomicString(errorDomainCurl), msg->data.result, url, String(curl_easy_strerror(msg->data.result))); ASCIILiteral > Source/WebCore/platform/network/curl/ResourceHandleManager.h:105 > +extern const char* const errorDomainCurl; This shouldn't be necessary.

Basuke Suzuki

Comment 9 2017-02-24 12:12:02 PST

Created attachment 302678 [details] Patch Fixed based on Alex review.

WebKit Commit Bot

Comment 10 2017-02-24 14:24:59 PST

Attachment 302678 [details] did not pass style-queue: ERROR: Source/WebCore/ChangeLog:8: You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible. [changelog/nonewtests] [5] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.

Basuke Suzuki

Comment 11 2017-02-24 14:32:29 PST

Created attachment 302691 [details] Patch

WebKit Commit Bot

Comment 12 2017-02-24 17:10:39 PST

Comment on attachment 302691 [details] Patch Clearing flags on attachment: 302691 Committed r212981: <http://trac.webkit.org/changeset/212981>

WebKit Commit Bot

Comment 13 2017-02-24 17:11:26 PST

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.