Bug 134404

Summary:

[Feature Queries] Enable Feature Queries on Mac

Product:

WebKit

Reporter:

Bear Travis <betravis>

Component:

CSS

Assignee:

Bear Travis <betravis>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

buildbot, bunhere, cdumez, commit-queue, esprehn+autocc, glenn, gyuyoung.kim, macpherson, menard, m.goleb+bugzilla, rniwa, sergio, simon.fraser, syoichi

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

134810

Bug Blocks:

134358

Attachments:

Description	Flags
Initial Patch	none
Archive of layout-test-results from webkit-ews-05 for mac-mountainlion	none
Updated Patch	none
Archive of layout-test-results from webkit-ews-07 for mac-mountainlion	none
Archive of layout-test-results from webkit-ews-01 for mac-mountainlion	none
Archive of layout-test-results from webkit-ews-11 for mac-mountainlion-wk2	none
Archive of layout-test-results from webkit-ews-04 for mac-mountainlion	none
Updated Patch	none
Archive of layout-test-results from webkit-ews-16 for mac-mountainlion-wk2	none
Updating Patch	none
Patch sans CSSGrammar changes	none

Bear Travis

Reported 2014-06-27 11:55:47 PDT

The Mac platform does not have ENABLE_CSS3_CONDITIONAL_RULES enabled, which turns on support for CSS3 feature queries. Turning it on will also enable it in the nightlies as an experimental feature.

Attachments
Initial Patch (7.53 KB, patch) 2014-06-27 12:11 PDT, Bear Travis	no flags	Details Formatted Diff Diff
Archive of layout-test-results from webkit-ews-05 for mac-mountainlion (493.52 KB, application/zip) 2014-06-27 15:33 PDT, Build Bot	no flags	Details
Updated Patch (8.82 KB, patch) 2014-07-07 12:09 PDT, Bear Travis	no flags	Details Formatted Diff Diff
Archive of layout-test-results from webkit-ews-07 for mac-mountainlion (510.48 KB, application/zip) 2014-07-07 14:40 PDT, Build Bot	no flags	Details
Archive of layout-test-results from webkit-ews-01 for mac-mountainlion (496.35 KB, application/zip) 2014-07-07 15:35 PDT, Build Bot	no flags	Details
Archive of layout-test-results from webkit-ews-11 for mac-mountainlion-wk2 (1.36 MB, application/zip) 2014-07-07 15:36 PDT, Build Bot	no flags	Details
Archive of layout-test-results from webkit-ews-04 for mac-mountainlion (556.22 KB, application/zip) 2014-07-07 16:28 PDT, Build Bot	no flags	Details
Updated Patch (9.56 KB, patch) 2014-07-08 16:02 PDT, Bear Travis	no flags	Details Formatted Diff Diff
Archive of layout-test-results from webkit-ews-16 for mac-mountainlion-wk2 (1.46 MB, application/zip) 2014-07-08 17:45 PDT, Build Bot	no flags	Details
Updating Patch (9.54 KB, patch) 2014-07-09 10:41 PDT, Bear Travis	no flags	Details Formatted Diff Diff
Patch sans CSSGrammar changes (7.57 KB, patch) 2014-07-11 12:51 PDT, Bear Travis	no flags	Details Formatted Diff Diff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.

Bear Travis

Comment 1 2014-06-27 12:11:48 PDT

Created attachment 234004 [details] Initial Patch

Build Bot

Comment 2 2014-06-27 15:33:07 PDT

Comment on attachment 234004 [details] Initial Patch Attachment 234004 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/5559618814083072 New failing tests: css3/supports-dom-api.html

Build Bot

Comment 3 2014-06-27 15:33:11 PDT

Created attachment 234025 [details] Archive of layout-test-results from webkit-ews-05 for mac-mountainlion The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: webkit-ews-05 Port: mac-mountainlion Platform: Mac OS X 10.8.5

Bear Travis

Comment 4 2014-07-07 12:09:16 PDT

Created attachment 234501 [details] Updated Patch Add an existence test for CSS.supports. Test runs locally, so debugging this failure may take a little legwork.

Build Bot

Comment 5 2014-07-07 14:40:34 PDT

Comment on attachment 234501 [details] Updated Patch Attachment 234501 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/5173918268653568 New failing tests: css3/supports-dom-api.html

Build Bot

Comment 6 2014-07-07 14:40:39 PDT

Created attachment 234512 [details] Archive of layout-test-results from webkit-ews-07 for mac-mountainlion The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: webkit-ews-07 Port: mac-mountainlion Platform: Mac OS X 10.8.5

Build Bot

Comment 7 2014-07-07 15:35:08 PDT

Comment on attachment 234501 [details] Updated Patch Attachment 234501 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/6008284116942848 New failing tests: css3/supports-dom-api.html

Build Bot

Comment 8 2014-07-07 15:35:16 PDT

Created attachment 234520 [details] Archive of layout-test-results from webkit-ews-01 for mac-mountainlion The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: webkit-ews-01 Port: mac-mountainlion Platform: Mac OS X 10.8.5

Build Bot

Comment 9 2014-07-07 15:36:29 PDT

Comment on attachment 234501 [details] Updated Patch Attachment 234501 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/5875380648935424 New failing tests: media/W3C/video/preload/preload_property_exists.html

Build Bot

Comment 10 2014-07-07 15:36:36 PDT

Created attachment 234521 [details] Archive of layout-test-results from webkit-ews-11 for mac-mountainlion-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: webkit-ews-11 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.5

Darin Adler

Comment 11 2014-07-07 16:09:35 PDT

Comment on attachment 234501 [details] Updated Patch View in context: https://bugs.webkit.org/attachment.cgi?id=234501&action=review Mac regression test is failing. > LayoutTests/css3/supports-dom-api.html:10 > + shouldBeDefined('window.CSS.supports'); I don’t understand why "window." is included here. If we were checking "window.CSS" then it would help, but for checking "CSS.supports" adding the "window." prefix doesn’t help.

Build Bot

Comment 12 2014-07-07 16:28:04 PDT

Comment on attachment 234501 [details] Updated Patch Attachment 234501 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/5822057690431488 New failing tests: css3/supports-dom-api.html

Build Bot

Comment 13 2014-07-07 16:28:12 PDT

Created attachment 234524 [details] Archive of layout-test-results from webkit-ews-04 for mac-mountainlion The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: webkit-ews-04 Port: mac-mountainlion Platform: Mac OS X 10.8.5

Bear Travis

Comment 14 2014-07-08 10:18:49 PDT

(In reply to comment #11) > (From update of attachment 234501 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=234501&action=review > > Mac regression test is failing. > > > LayoutTests/css3/supports-dom-api.html:10 > > + shouldBeDefined('window.CSS.supports'); > > I don’t understand why "window." is included here. If we were checking "window.CSS" then it would help, but for checking "CSS.supports" adding the "window." prefix doesn’t help. Ah, yes. The test was meant to ensure that CSS exists on the window object, but it would make more sense to just test window.CSS then. Will fix this up in the next iteration, still working through the test failures.

Bear Travis

Comment 15 2014-07-08 16:02:55 PDT

Created attachment 234603 [details] Updated Patch Some of the CSS productions were not properly returning values, which caused the release build to crash in certain cases.

Build Bot

Comment 16 2014-07-08 17:45:15 PDT

Comment on attachment 234603 [details] Updated Patch Attachment 234603 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/6676936705179648 New failing tests: media/W3C/video/networkState/networkState_during_loadstart.html

Build Bot

Comment 17 2014-07-08 17:45:20 PDT

Created attachment 234609 [details] Archive of layout-test-results from webkit-ews-16 for mac-mountainlion-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: webkit-ews-16 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.5

Bear Travis

Comment 18 2014-07-09 10:41:11 PDT

Created attachment 234643 [details] Updating Patch

Antti Koivisto

Comment 19 2014-07-10 11:39:22 PDT

Comment on attachment 234643 [details] Updating Patch View in context: https://bugs.webkit.org/attachment.cgi?id=234643&action=review > Source/WebCore/css/CSSGrammar.y.in:747 > - | supports_declaration_condition > - | '(' error ')' > + | supports_declaration_condition { $$ = $1; } > + | '(' error ')' { $$ = false; } Please do any non-build file changes separately.

Bear Travis

Comment 20 2014-07-11 12:51:35 PDT

Created attachment 234775 [details] Patch sans CSSGrammar changes Moved the changes to GSSGrammar.y.in to bug 134358.

WebKit Commit Bot

Comment 21 2014-07-14 13:12:52 PDT

Comment on attachment 234775 [details] Patch sans CSSGrammar changes Clearing flags on attachment: 234775 Committed r171075: <http://trac.webkit.org/changeset/171075>

WebKit Commit Bot

Comment 22 2014-07-14 13:13:01 PDT

All reviewed patches have been landed. Closing bug.

Benjamin Poulain

Comment 23 2014-10-04 15:01:20 PDT

*** Bug 126636 has been marked as a duplicate of this bug. ***

Note You need to log in before you can comment on or make changes to this bug.