Bug 137253

Summary: [CSS Grid Layout] Pass the valid set of tracks to grow beyond growth limits
Product: WebKit Reporter: Sergio Villar Senin <svillar>
Component: New BugsAssignee: Sergio Villar Senin <svillar>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, darin, esprehn+autocc, glenn, jfernandez, kling, kondapallykalyan, rego
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 60731    
Attachments:
Description Flags
Patch darin: review+

Sergio Villar Senin
Reported 2014-09-30 08:31:09 PDT
[CSS Grid Layout] Pass the valid set of tracks to grow beyond growth limits
Attachments
Patch (17.42 KB, patch)
2014-09-30 08:38 PDT, Sergio Villar Senin 		darin: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Sergio Villar Senin
Comment 1 2014-09-30 08:38:23 PDT
Created attachment 238927 [details] Patch
Darin Adler
Comment 2 2014-10-03 09:07:18 PDT
Comment on attachment 238927 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=238927&action=review > Source/WebCore/rendering/RenderGrid.cpp:584 > +void RenderGrid::resolveContentBasedTrackSizingFunctionsForItems(GridTrackSizingDirection direction, GridSizingData& sizingData, GridItemWithSpan& gridItemWithSpan, FilterFunction filterFunction, SizingFunction sizingFunction, AccumulatorGetter trackGetter, AccumulatorGrowFunction trackGrowthFunction, FilterFunction growAboveMaxBreadthFilterFunction) I’m concerned that the extensive use of pointers to member function for these functions is an inefficient design pattern. But this is only a suspicion, not something I am certain about.
Sergio Villar Senin
Comment 3 2014-10-13 01:44:34 PDT
Committed r174643: <http://trac.webkit.org/changeset/174643>
Note You need to log in before you can comment on or make changes to this bug.