Bug 138411

Summary: [GTK] Expose user script messages to GObject DOM bindings
Product: WebKit Reporter: Carlos Garcia Campos <cgarcia>
Component: BindingsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: aperez, gustavo, pnormand
Priority: P2 Keywords: Gtk
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 138409    
Bug Blocks: 125775    
Attachments:
Description Flags
Patch pnormand: review+

Carlos Garcia Campos
Reported 2014-11-05 00:44:27 PST
ssia
Attachments
Patch (14.55 KB, patch)
2014-11-05 01:00 PST, Carlos Garcia Campos 		pnormand: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Carlos Garcia Campos
Comment 1 2014-11-05 01:00:57 PST
Created attachment 241009 [details] Patch The "raw" API is not very convenient to use, we should add custom API to make it easier to use.
Philippe Normand
Comment 2 2014-11-11 00:30:23 PST
Comment on attachment 241009 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=241009&action=review > Source/WebCore/bindings/scripts/CodeGeneratorGObject.pm:1586 > + return scalar(grep {$_ eq $domClassName} qw(WebKitDOMDOMWindow WebKitDOMUserMessageHandlersNamespace)); Kind of sad to hardcode this here :( Is this the only way?
Carlos Garcia Campos
Comment 3 2014-11-11 01:02:47 PST
(In reply to comment #2) > Comment on attachment 241009 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=241009&action=review > > > Source/WebCore/bindings/scripts/CodeGeneratorGObject.pm:1586 > > + return scalar(grep {$_ eq $domClassName} qw(WebKitDOMDOMWindow WebKitDOMUserMessageHandlersNamespace)); > > Kind of sad to hardcode this here :( Is this the only way? Not easily. When generating code, we know which symbols are not stable (the ones not in the stable symbols list), but custom symbols are not generated but manually implemented. The code generator knows which symbols require a custom implementation, but it doesn't know which custom symbols are actually implemented manually (most of them are simply not implemented).
Philippe Normand
Comment 4 2014-11-11 02:39:22 PST
Comment on attachment 241009 [details] Patch Ok then.
Carlos Garcia Campos
Comment 5 2014-11-12 04:30:54 PST
Committed r176018: <http://trac.webkit.org/changeset/176018>
Note You need to log in before you can comment on or make changes to this bug.