Bug 138728

Summary: Two WKWebView internal methods are implemented in a category
Product: WebKit Reporter: mitz
Component: WebKit2Assignee: mitz
Status: RESOLVED FIXED    
Severity: Normal CC: bdakin, buildbot, commit-queue, rniwa, thorton
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Move the implementations from the category into the class
thorton: review+, buildbot: commit-queue-
Archive of layout-test-results from webkit-ews-13 for mac-mountainlion-wk2 none

mitz
Reported 2014-11-13 21:57:14 PST
-[WKWebView _ignoresNonWheelMouseEvents] and -[WKWebView _setIgnoresNonWheelMouseEvents:] are part of a class extension, but have implementations in WKWebView (WKPrivate), which override the synthesized accessors (since there are no overrides in the class @implementation). Fortunately the linker emits warnings about this: ld: warning: instance method '_setIgnoresNonWheelMouseEvents:' in category from WebKit2.build/Debug/WebKit.build/Objects-normal/x86_64/WKWebView.o overrides method from class in WebKit2.build/Debug/WebKit.build/Objects-normal/x86_64/WKWebView.o ld: warning: instance method '_ignoresNonWheelMouseEvents' in category from WebKit2.build/Debug/WebKit.build/Objects-normal/x86_64/WKWebView.o overrides method from class in WebKit2.build/Debug/WebKit.build/Objects-normal/x86_64/WKWebView.o
Attachments
Move the implementations from the category into the class (1.84 KB, patch)
2014-11-13 21:58 PST, mitz 		thorton: review+
buildbot: commit-queue-
DetailsFormatted DiffDiff
Archive of layout-test-results from webkit-ews-13 for mac-mountainlion-wk2 (587.42 KB, application/zip)
2014-11-13 22:56 PST, Build Bot 		no flags
Details
View All Add attachment proposed patch, testcase, etc.
mitz
Comment 1 2014-11-13 21:58:37 PST
Created attachment 241556 [details] Move the implementations from the category into the class
Build Bot
Comment 2 2014-11-13 22:56:50 PST
Comment on attachment 241556 [details] Move the implementations from the category into the class Attachment 241556 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/5109783686283264 Number of test failures exceeded the failure limit.
Build Bot
Comment 3 2014-11-13 22:56:53 PST
Created attachment 241559 [details] Archive of layout-test-results from webkit-ews-13 for mac-mountainlion-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: webkit-ews-13 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.5
mitz
Comment 4 2014-11-13 22:58:26 PST
Fixed in <http://trac.webkit.org/r176116>.
Alexey Proskuryakov
Comment 5 2014-11-14 10:18:22 PST
Filed bug 138743 for EWS false rejection.
Note You need to log in before you can comment on or make changes to this bug.