Bug 139668

Summary: Move WebCore/platform/image-decoders to std::unique_ptr<>
Product: WebKit Reporter: Gyuyoung Kim <gyuyoung.kim>
Component: New BugsAssignee: Gyuyoung Kim <gyuyoung.kim>
Status: RESOLVED FIXED    
Severity: Normal CC: darin
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 128007    
Attachments:
Description Flags
Patch kling: review+

Gyuyoung Kim
Reported 2014-12-15 20:17:23 PST
SSIA
Attachments
Patch (16.53 KB, patch)
2014-12-15 20:19 PST, Gyuyoung Kim 		kling: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Gyuyoung Kim
Comment 1 2014-12-15 20:19:03 PST
Created attachment 243339 [details] Patch
Andreas Kling
Comment 2 2014-12-16 18:07:45 PST
Comment on attachment 243339 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=243339&action=review r=me > Source/WebCore/platform/image-decoders/ico/ICOImageDecoder.h:144 > + typedef Vector<std::unique_ptr<BMPImageReader> > BMPReaders; Templates can end in ">>" nowadays, no need for "> >" > Source/WebCore/platform/image-decoders/ico/ICOImageDecoder.h:146 > + typedef Vector<std::unique_ptr<PNGImageDecoder> > PNGDecoders; Ditto.
Gyuyoung Kim
Comment 3 2014-12-16 18:11:19 PST
Committed r177423: <http://trac.webkit.org/changeset/177423>
Gyuyoung Kim
Comment 4 2014-12-16 18:24:23 PST
(In reply to comment #2) > Comment on attachment 243339 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=243339&action=review > > r=me > > > Source/WebCore/platform/image-decoders/ico/ICOImageDecoder.h:144 > > + typedef Vector<std::unique_ptr<BMPImageReader> > BMPReaders; > > Templates can end in ">>" nowadays, no need for "> >" > > > Source/WebCore/platform/image-decoders/ico/ICOImageDecoder.h:146 > > + typedef Vector<std::unique_ptr<PNGImageDecoder> > PNGDecoders; > > Ditto. Fixed all, Thanks.
Note You need to log in before you can comment on or make changes to this bug.