Bug 142436

Summary: The code to link FunctionExecutable is duplicated everywhere
Product: WebKit Reporter: Ryosuke Niwa <rniwa>
Component: JavaScriptCoreAssignee: Ryosuke Niwa <rniwa>
Status: RESOLVED FIXED    
Severity: Normal CC: barraclough, benjamin, fpizlo, ggaren, mark.lam, msaboff, oliver
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 142388    
Attachments:
Description Flags
Patch
none
Fixed the bug title
none
Cleanup darin: review+

Ryosuke Niwa
Reported 2015-03-07 01:18:02 PST
There's a lot of code duplicated to adjust offsets within SourceCode. Refactor them into two functions.
Attachments
Patch (13.38 KB, patch)
2015-03-07 01:25 PST, Ryosuke Niwa 		no flags
DetailsFormatted DiffDiff
Fixed the bug title (13.37 KB, patch)
2015-03-07 01:27 PST, Ryosuke Niwa 		no flags
DetailsFormatted DiffDiff
Cleanup (13.35 KB, patch)
2015-03-07 01:36 PST, Ryosuke Niwa 		darin: review+
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Ryosuke Niwa
Comment 1 2015-03-07 01:25:53 PST
Created attachment 248150 [details] Patch
Ryosuke Niwa
Comment 2 2015-03-07 01:27:50 PST
Created attachment 248151 [details] Fixed the bug title
Ryosuke Niwa
Comment 3 2015-03-07 01:36:41 PST
Created attachment 248152 [details] Cleanup
Darin Adler
Comment 4 2015-03-07 08:51:12 PST
Comment on attachment 248152 [details] Cleanup View in context: https://bugs.webkit.org/attachment.cgi?id=248152&action=review > Source/JavaScriptCore/bytecode/UnlinkedCodeBlock.cpp:144 > + // The unlinkedBodyEndColumn is based-0. Hence, we need to add 1 to it. But if the The term is "0-based", not "based-0". Would be nice to fix this since you are moving this comment into a new function.
Filip Pizlo
Comment 5 2015-03-07 09:05:03 PST
Comment on attachment 248152 [details] Cleanup Thanks for doing this!
Ryosuke Niwa
Comment 6 2015-03-07 13:44:54 PST
(In reply to comment #4) > Comment on attachment 248152 [details] > Cleanup > > View in context: > https://bugs.webkit.org/attachment.cgi?id=248152&action=review > > > Source/JavaScriptCore/bytecode/UnlinkedCodeBlock.cpp:144 > > + // The unlinkedBodyEndColumn is based-0. Hence, we need to add 1 to it. But if the > > The term is "0-based", not "based-0". Would be nice to fix this since you > are moving this comment into a new function. Thanks for the review. Will fix!
Ryosuke Niwa
Comment 7 2015-03-07 14:10:34 PST
Committed r181213: <http://trac.webkit.org/changeset/181213>
Note You need to log in before you can comment on or make changes to this bug.