Bug 143238

Summary: [New Block-Inside-Inline Model] Make sure breaks occur both before and after the anonymous inline-block
Product: WebKit Reporter: Dave Hyatt <hyatt>
Component: Layout and RenderingAssignee: Dave Hyatt <hyatt>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, esprehn+autocc, glenn, kondapallykalyan, mmaxfield
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch dino: review+

Dave Hyatt
Reported 2015-03-30 15:02:30 PDT
Make sure line breaks occur both before and after the anonymous inline-block.
Attachments
Patch (17.18 KB, patch)
2015-03-30 15:08 PDT, Dave Hyatt 		dino: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Dave Hyatt
Comment 1 2015-03-30 15:08:11 PDT
Created attachment 249769 [details] Patch
Dave Hyatt
Comment 2 2015-03-31 10:43:20 PDT
Fixed in r182188.
Jon Lee
Comment 3 2015-03-31 11:21:58 PDT
Comment on attachment 249769 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=249769&action=review > Source/WebCore/rendering/RenderBlockFlow.cpp:4118 > + if (((canBreakReplacedElement && (autoWrap || oldAutoWrap) && (!isPrevChildInlineFlow || shouldBreakLineAfterText)) || clearPreviousFloat) || isAnonymousInlineBlock) { is the extra parenthesis necessary? you've got ((...) || clearPreviousFloat || isAnonymousInlineBlock)
Note You need to log in before you can comment on or make changes to this bug.