Bug 144243

Summary: Getter or setter method named "prototype" or "constructor" should throw SyntaxError
Product: WebKit Reporter: Ryosuke Niwa <rniwa>
Component: JavaScriptCoreAssignee: Ryosuke Niwa <rniwa>
Status: RESOLVED FIXED    
Severity: Normal CC: barraclough, benjamin, commit-queue, darin, fpizlo, ggaren, mark.lam
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 140491    
Attachments:
Description Flags
Fixes the bug none

Ryosuke Niwa
Reported 2015-04-26 17:47:34 PDT
We shouldn't allow getter or setter (either instance and static) method of name "prototype" or "constructor".
Attachments
Fixes the bug (11.60 KB, patch)
2015-04-26 18:27 PDT, Ryosuke Niwa 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Ryosuke Niwa
Comment 1 2015-04-26 18:27:33 PDT
Created attachment 251716 [details] Fixes the bug
Ryosuke Niwa
Comment 2 2015-04-26 20:32:12 PDT
Comment on attachment 251716 [details] Fixes the bug Thanks for the review!
WebKit Commit Bot
Comment 3 2015-04-26 21:19:31 PDT
Comment on attachment 251716 [details] Fixes the bug Clearing flags on attachment: 251716 Committed r183382: <http://trac.webkit.org/changeset/183382>
WebKit Commit Bot
Comment 4 2015-04-26 21:19:39 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.