Bug 147104

Summary: Remove RenderTheme::shouldShowPlaceholderWhenFocused()
Product: WebKit Reporter: Carlos Garcia Campos <cgarcia>
Component: Layout and RenderingAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: darin, gustavo, mrobinson, rniwa
Priority: P2 Keywords: Gtk
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch mrobinson: review+

Carlos Garcia Campos
Reported 2015-07-20 02:57:04 PDT
GTK+ is the only port that returns false in shouldShowPlaceholderWhenFocused(). That's inconsistent with all other browsers that show the placeholder text even for focused entries in all platforms. We should change the GTK+ port behaviour, but that would leave all implementations of shouldShowPlaceholderWhenFocused returning true, so let's just remove it.
Attachments
Patch (6.94 KB, patch)
2015-07-20 02:59 PDT, Carlos Garcia Campos 		mrobinson: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Carlos Garcia Campos
Comment 1 2015-07-20 02:59:43 PDT
Created attachment 257084 [details] Patch This makes the GTK+ port consistent with all other browsers, but inconsistent with GTK+ itself, I'll write a patch for GTK+.
Carlos Garcia Campos
Comment 2 2015-07-20 03:07:39 PDT
See https://bugzilla.gnome.org/show_bug.cgi?id=752622
Carlos Garcia Campos
Comment 3 2015-07-20 22:35:18 PDT
Committed r187095: <http://trac.webkit.org/changeset/187095>
Note You need to log in before you can comment on or make changes to this bug.