Bug 147636

Summary: [Win] build-webkit and MSBuild fight over BuildOutput.htm, causing build failures.
Product: WebKit Reporter: Brent Fulgham <bfulgham>
Component: Tools / TestsAssignee: Brent Fulgham <bfulgham>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, ap, bfulgham, commit-queue, ossy, peavo
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Brent Fulgham
Reported 2015-08-04 11:17:42 PDT
We started trying to capture build failures into our build log back in 2013, and added special logic for Visual Studio Express because the build driver was not emitting errors to stdout. However, in Bug 140845 we switched to MSBuild for all builds, which handles this output properly. Since MSBuild uses BuildOutput.htm directly, the file can be locked by MSBuild activity causing the overall build process to fail due to the 'die' command in the build-webkit Perl script. We no longer need build-webkit to manually troll the log data and pipe it to stdout; MSBuild is already doing this properly. Remove this unneeded (and bug-prone) code to improve the build reliability.
Attachments
Patch (1.81 KB, patch)
2015-08-04 11:20 PDT, Brent Fulgham 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Brent Fulgham
Comment 1 2015-08-04 11:20:32 PDT
Created attachment 258186 [details] Patch
Alex Christensen
Comment 2 2015-08-04 12:05:18 PDT
Comment on attachment 258186 [details] Patch r=me I was thinking about doing this last week Do you think this will help with https://bugs.webkit.org/show_bug.cgi?id=146628
WebKit Commit Bot
Comment 3 2015-08-04 12:11:04 PDT
Comment on attachment 258186 [details] Patch Clearing flags on attachment: 258186 Committed r187874: <http://trac.webkit.org/changeset/187874>
WebKit Commit Bot
Comment 4 2015-08-04 12:11:08 PDT
All reviewed patches have been landed. Closing bug.
Brent Fulgham
Comment 5 2015-08-04 12:18:07 PDT
(In reply to comment #2) > Comment on attachment 258186 [details] > Patch > > r=me > I was thinking about doing this last week > Do you think this will help with > https://bugs.webkit.org/show_bug.cgi?id=146628 That's my hope. I'm trying to track down any errors or differences in EWS versus the other builds.
Note You need to log in before you can comment on or make changes to this bug.