Bug 148741

Summary: RepatchBuffer should be stateless
Product: WebKit Reporter: Filip Pizlo <fpizlo>
Component: JavaScriptCoreAssignee: Filip Pizlo <fpizlo>
Status: RESOLVED FIXED    
Severity: Normal CC: barraclough, basile_clement, benjamin, ggaren, mark.lam, mhahnenb, msaboff, nrotem, oliver, saam, sam
Priority: P2    
Version: Other   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 148742    
Attachments:
Description Flags
the patch
none
more fixes ggaren: review+

Filip Pizlo
Reported 2015-09-03 11:15:16 PDT
We use the CodeBlock* field of RepatchBuffer in various places. Usually, when we use this field, we're doing it wrong, since we never really know which CodeBlock* the RepatchBuffer points to. Also, this field was there to support WX_EXCLUSIVE, which doesn't work anymore and probably never will (since nobody is working on it). Killing that feature means that we no longer have to be careful about caching a RepatchBuffer and passing it around.
Attachments
the patch (34.81 KB, patch)
2015-09-03 11:24 PDT, Filip Pizlo 		no flags
DetailsFormatted DiffDiff
more fixes (34.92 KB, patch)
2015-09-03 11:29 PDT, Filip Pizlo 		ggaren: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Filip Pizlo
Comment 1 2015-09-03 11:24:43 PDT
Created attachment 260498 [details] the patch
Filip Pizlo
Comment 2 2015-09-03 11:29:12 PDT
Created attachment 260500 [details] more fixes
Geoffrey Garen
Comment 3 2015-09-03 11:30:32 PDT
Comment on attachment 260500 [details] more fixes r=me
Filip Pizlo
Comment 4 2015-09-03 12:42:12 PDT
Landed in http://trac.webkit.org/changeset/189278
Note You need to log in before you can comment on or make changes to this bug.