Bug 150150

Summary: Modern IDB: Support IDBDatabase.close()
Product: WebKit Reporter: Brady Eidson <beidson>
Component: WebCore Misc.Assignee: Brady Eidson <beidson>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, alecflett, buildbot, commit-queue, jsbell, rniwa
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 150215    
Bug Blocks: 149117    
Attachments:
Description Flags
Patch v1
achristensen: review+, buildbot: commit-queue-
Archive of layout-test-results from ews102 for mac-mavericks
none
Patch for landing none

Brady Eidson
Reported 2015-10-14 16:15:02 PDT
Modern IDB: Support IDBDatabase.close() Now that we support versionchange events to open database connections (https://bugs.webkit.org/show_bug.cgi?id=150149), we need to support IDBDatabase.close() to respond to them.
Attachments
Patch v1 (20.22 KB, patch)
2015-10-15 15:52 PDT, Brady Eidson 		achristensen: review+
buildbot: commit-queue-
DetailsFormatted DiffDiff
Archive of layout-test-results from ews102 for mac-mavericks (720.54 KB, application/zip)
2015-10-15 16:33 PDT, Build Bot 		no flags
Details
Patch for landing (25.89 KB, patch)
2015-10-16 09:32 PDT, Brady Eidson 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Brady Eidson
Comment 1 2015-10-15 09:50:21 PDT
Actually, this does not rely on 150149, and doing it earlier will help with other tests.
Brady Eidson
Comment 2 2015-10-15 15:52:00 PDT
Created attachment 263211 [details] Patch v1
Alex Christensen
Comment 3 2015-10-15 16:02:42 PDT
Comment on attachment 263211 [details] Patch v1 View in context: https://bugs.webkit.org/attachment.cgi?id=263211&action=review > LayoutTests/storage/indexeddb/modern/opendatabase-versions.html:37 > + request.transaction.db.close(); Try closing it twice in a test.
Build Bot
Comment 4 2015-10-15 16:33:28 PDT
Comment on attachment 263211 [details] Patch v1 Attachment 263211 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/293001 New failing tests: storage/websql/alter-to-info-table.html
Build Bot
Comment 5 2015-10-15 16:33:30 PDT
Created attachment 263219 [details] Archive of layout-test-results from ews102 for mac-mavericks The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews102 Port: mac-mavericks Platform: Mac OS X 10.9.5
Brady Eidson
Comment 6 2015-10-15 17:10:05 PDT
It seems extremely unlikely that the test failures seem on mac-wk1 could be because of this patch. Will look into them before landing.
Brady Eidson
Comment 7 2015-10-15 17:10:39 PDT
(In reply to comment #6) > It seems extremely unlikely that the test failures seem on mac-wk1 could be > because of this patch. > > Will look into them before landing. As is evidenced by: > Unable to pass tests without patch (tree is red?) [results]
Brady Eidson
Comment 8 2015-10-15 17:24:30 PDT
It's obvious on the bots that the tests are in terrible shape right now. Builds fine locally, landing soon.
Brady Eidson
Comment 9 2015-10-15 17:25:55 PDT
https://trac.webkit.org/changeset/191156
Brady Eidson
Comment 10 2015-10-15 17:26:50 PDT
Yikes! A new failure was introduced. Sorry. Trying to rollout now.
WebKit Commit Bot
Comment 11 2015-10-15 17:30:05 PDT
Re-opened since this is blocked by bug 150215
Brady Eidson
Comment 12 2015-10-15 19:56:33 PDT
Looks like leftovers from an indexeddb test causing a crash (ASSERT) in the first following test - storage/websql/alter-to-info-table.html That said, can't reproduce locally :(
Brady Eidson
Comment 13 2015-10-15 19:57:35 PDT
Looks like an error callback from the server coming through to the client *after* the test is over... maybe.
Brady Eidson
Comment 14 2015-10-15 20:10:18 PDT
Looks like a release build failure, possibly changing timing enough to cause this latent callback to come in.
Brady Eidson
Comment 15 2015-10-15 20:19:34 PDT
(In reply to comment #14) > Looks like a release build failure, possibly changing timing enough to cause > this latent callback to come in. I spotted the obvious bug in the test, and it revealed a very real IDBError crash. Updated patch incoming.
Brady Eidson
Comment 16 2015-10-16 09:32:21 PDT
Created attachment 263275 [details] Patch for landing Fixed the issues, I'll just let the CQ deal with landing this.
WebKit Commit Bot
Comment 17 2015-10-16 10:19:35 PDT
Comment on attachment 263275 [details] Patch for landing Clearing flags on attachment: 263275 Committed r191182: <http://trac.webkit.org/changeset/191182>
Note You need to log in before you can comment on or make changes to this bug.