Bug 150188

Summary:

Remove deprecated function insertRule() from http/tests/css/resources/shared-stylesheet-mutation.js

Product:

WebKit

Reporter:

Ryan Haddad <ryanhaddad>

Component:

Tools / Tests

Assignee:

Ryan Haddad <ryanhaddad>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

buildbot, commit-queue, dino, lforschler, rniwa

Priority:

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Archive of layout-test-results from ews101 for mac-mavericks	none
Archive of layout-test-results from ews104 for mac-mavericks-wk2	none
follow-up fix	commit-queue: commit-queue-
follow-up fix	ap: commit-queue+

Ryan Haddad

Reported 2015-10-15 14:25:00 PDT

Remove deprecated function insertRule() from http/tests/css/resources/shared-stylesheet-mutation.js The function was deprecated with https://bugs.webkit.org/show_bug.cgi?id=150113, causing the following two LayoutTests to fail due to the deprecation warning: http/tests/css/shared-stylesheet-mutation-preconstruct.html http/tests/css/shared-stylesheet-mutation-preconstruct.html

Attachments
Patch (3.04 KB, patch) 2015-10-15 14:26 PDT, Ryan Haddad	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews101 for mac-mavericks (650.78 KB, application/zip) 2015-10-15 15:03 PDT, Build Bot	no flags	Details
Archive of layout-test-results from ews104 for mac-mavericks-wk2 (686.42 KB, application/zip) 2015-10-15 15:09 PDT, Build Bot	no flags	Details
follow-up fix (2.65 KB, patch) 2015-10-15 18:01 PDT, Alexey Proskuryakov	commit-queue: commit-queue-	Details Formatted Diff Diff
follow-up fix (2.67 KB, patch) 2015-10-15 18:12 PDT, Alexey Proskuryakov	ap: commit-queue+	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Ryan Haddad

Comment 1 2015-10-15 14:26:42 PDT

Created attachment 263190 [details] Patch

Build Bot

Comment 2 2015-10-15 15:03:49 PDT

Comment on attachment 263190 [details] Patch Attachment 263190 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/292703 New failing tests: http/tests/css/shared-stylesheet-mutation.html http/tests/css/shared-stylesheet-mutation-preconstruct.html

Build Bot

Comment 3 2015-10-15 15:03:52 PDT

Created attachment 263194 [details] Archive of layout-test-results from ews101 for mac-mavericks The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews101 Port: mac-mavericks Platform: Mac OS X 10.9.5

Build Bot

Comment 4 2015-10-15 15:09:39 PDT

Comment on attachment 263190 [details] Patch Attachment 263190 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/292711 New failing tests: http/tests/css/shared-stylesheet-mutation.html http/tests/css/shared-stylesheet-mutation-preconstruct.html

Build Bot

Comment 5 2015-10-15 15:09:41 PDT

Created attachment 263195 [details] Archive of layout-test-results from ews104 for mac-mavericks-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews104 Port: mac-mavericks-wk2 Platform: Mac OS X 10.9.5

Dean Jackson

Comment 6 2015-10-15 16:18:51 PDT

Comment on attachment 263190 [details] Patch Clearing flags on attachment: 263190 Committed r191147: <http://trac.webkit.org/changeset/191147>

Dean Jackson

Comment 7 2015-10-15 16:18:59 PDT

All reviewed patches have been landed. Closing bug.

Ryan Haddad

Comment 8 2015-10-15 17:15:16 PDT

Reopening since these tests still seems to be failing.

Alexey Proskuryakov

Comment 9 2015-10-15 18:01:08 PDT

Created attachment 263235 [details] follow-up fix

WebKit Commit Bot

Comment 10 2015-10-15 18:03:16 PDT

Comment on attachment 263235 [details] follow-up fix Rejecting attachment 263235 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-02', 'validate-changelog', '--check-oops', '--non-interactive', 263235, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit /Volumes/Data/EWS/WebKit/LayoutTests/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive). Full output: http://webkit-queues.webkit.org/results/293314

Alexey Proskuryakov

Comment 11 2015-10-15 18:12:05 PDT

Created attachment 263236 [details] follow-up fix

Dean Jackson

Comment 12 2015-10-15 18:34:15 PDT

Committed r191158: <http://trac.webkit.org/changeset/191158>

Note You need to log in before you can comment on or make changes to this bug.