Bug 151344

Summary: [GTK] WebRTC: Update MediaStream "active state" definition when the specification is fixed
Product: WebKit Reporter: Adam Bergkvist <adam.bergkvist>
Component: WebCore Misc.Assignee: Philippe Normand <pnormand>
Status: NEW    
Severity: Normal CC: aperez, bugs-noreply, clopez, eric.carlson, ews-watchlist, glenn, hta, jer.noble, philipj, pnormand, sergio, tommyw
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 143211    
Attachments:
Description Flags
Patch aperez: review+

Adam Bergkvist
Reported 2015-11-17 02:39:33 PST
As of writing, the Media Capture and Stream specification [1] has some inconsistencies with regards to the MediaStream "active state". [1] http://w3c.github.io/mediacapture-main/archives/20150925/getusermedia.html
Attachments
Patch (3.17 KB, patch)
2021-08-16 07:39 PDT, Philippe Normand 		aperez: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Adam Bergkvist
Comment 1 2015-11-17 03:06:49 PST
The proposed patch for https://webkit.org/b/151346 skips two tests and refers to this bug.
Adam Bergkvist
Comment 2 2015-11-17 14:42:41 PST
https://webkit.org/b/151346 mentioned above was closed as a duplicate. New bug is: https://webkit.org/b/151360
Adam Bergkvist
Comment 3 2015-12-09 02:23:18 PST
Spec update is under way https://github.com/w3c/mediacapture-main/pull/291
Carlos Alberto Lopez Perez
Comment 4 2017-01-17 17:52:35 PST
The tests fast/mediastream/MediaStream-add-ended-tracks.html and fast/mediastream/MediaStream-add-remove-tracks.html are marked as passing on the Mac port. On GTK+ fast/mediastream/MediaStream-add-ended-tracks.html timeouts and fast/mediastream/MediaStream-add-remove-tracks.html fails with this diff: --- /home/clopez/webkit/webkit/layout-test-results/fast/mediastream/MediaStream-add-remove-tracks-expected.txt +++ /home/clopez/webkit/webkit/layout-test-results/fast/mediastream/MediaStream-add-remove-tracks-actual.txt @@ -49,19 +49,10 @@ PASS stream2.getVideoTracks().length is 0 *** active attribute is still true (until event is fired) -PASS stream2.active is true - -Stream2 is inactive. -PASS stream2.active is false - -*** add non-ended track -PASS audioTrack.readyState is not "ended" - -*** active attribute is still false (until event is fired) -PASS stream2.active is false +FAIL stream2.active should be true. Was false. Stream2 is active. -PASS stream2.active is true +FAIL stream2.active should be true. Was false. PASS successfullyParsed is true TEST COMPLETE Updated the GTK+ expectations file in r210841: <http://trac.webkit.org/changeset/210841>
Philippe Normand
Comment 5 2021-08-16 07:39:37 PDT
Created attachment 435601 [details] Patch
Note You need to log in before you can comment on or make changes to this bug.