Bug 151423

Summary: FTL should be able to compile a small function with B3
Product: WebKit Reporter: Filip Pizlo <fpizlo>
Component: JavaScriptCoreAssignee: Filip Pizlo <fpizlo>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, commit-queue, keith_miller, mark.lam, msaboff, saam
Priority: P2    
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 150279    
Attachments:
Description Flags
work in progress
none
work in progress
none
Patch
none
Patch none

Filip Pizlo
Reported 2015-11-18 16:24:41 PST
...
Attachments
work in progress (57.66 KB, patch)
2015-11-18 16:25 PST, Filip Pizlo 		no flags
DetailsFormatted DiffDiff
work in progress (65.59 KB, patch)
2015-11-18 16:43 PST, Filip Pizlo 		no flags
DetailsFormatted DiffDiff
Patch (87.62 KB, patch)
2015-11-18 18:22 PST, Benjamin Poulain 		no flags
DetailsFormatted DiffDiff
Patch (87.57 KB, patch)
2015-11-18 18:41 PST, Benjamin Poulain 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Filip Pizlo
Comment 1 2015-11-18 16:25:15 PST
Created attachment 265805 [details] work in progress
Filip Pizlo
Comment 2 2015-11-18 16:43:58 PST
Created attachment 265809 [details] work in progress
Benjamin Poulain
Comment 3 2015-11-18 18:22:52 PST
Created attachment 265821 [details] Patch
WebKit Commit Bot
Comment 4 2015-11-18 18:24:45 PST
Attachment 265821 [details] did not pass style-queue: ERROR: Source/JavaScriptCore/ftl/FTLLowerDFGToLLVM.cpp:9061: Place brace on its own line for function definitions. [whitespace/braces] [4] Total errors found: 1 in 15 files If any of these errors are false positives, please file a bug against check-webkit-style.
Filip Pizlo
Comment 5 2015-11-18 18:31:31 PST
Comment on attachment 265821 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=265821&action=review I think that we can have a better story for upsilons. I think that having anchor() create one for you, and then making ValueFromBlock hold onto it, is the most natural. > Source/JavaScriptCore/ftl/FTLB3Output.h:368 > + ValueFromBlock anchor(LValue value) > + { > + return ValueFromBlock(value, m_block); > + } Either this should create an Upsilon for you by simply appending it to m_block... > Source/JavaScriptCore/ftl/FTLB3Output.h:407 > +inline void Output::addIncomingToPhi(LValue phi, ValueFromBlock value) > +{ > + value.value()->as<B3::UpsilonValue>()->setPhi(phi); > +} ... or this should create an Upsilon for you by appending it to the block that your value came from.
Benjamin Poulain
Comment 6 2015-11-18 18:41:11 PST
Created attachment 265824 [details] Patch
WebKit Commit Bot
Comment 7 2015-11-18 18:44:07 PST
Attachment 265824 [details] did not pass style-queue: ERROR: Source/JavaScriptCore/ftl/FTLLowerDFGToLLVM.cpp:9061: Place brace on its own line for function definitions. [whitespace/braces] [4] Total errors found: 1 in 15 files If any of these errors are false positives, please file a bug against check-webkit-style.
Benjamin Poulain
Comment 8 2015-11-18 18:48:49 PST
Comment on attachment 265824 [details] Patch Clearing flags on attachment: 265824 Committed r192605: <http://trac.webkit.org/changeset/192605>
Benjamin Poulain
Comment 9 2015-11-18 18:48:54 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.