Bug 151481

Summary:

Modern IDB: In the VersionChangeEvent for delete database calls, newVersion should be null instead of 0

Product:

WebKit

Reporter:

Brady Eidson <beidson>

Component:

WebCore Misc.

Assignee:

Brady Eidson <beidson>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

achristensen, alecflett, cdumez, commit-queue, esprehn+autocc, jsbell, kondapallykalyan

Priority:

Version:

Other

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

151456

Bug Blocks:

149117

Attachments:

Description	Flags
Patch v1	none
Patch v2 - Shot in the dark...	none
Patch v3	sam: review-
Patch v4	none
Patch v5	sam: review+

Brady Eidson

Reported 2015-11-19 21:53:59 PST

Modern IDB: In the VersionChangeEvent for delete database calls, oldVersion should be null instead of 0

Attachments
Patch v1 (10.77 KB, patch) 2015-11-20 11:16 PST, Brady Eidson	no flags	Details Formatted Diff Diff
Patch v2 - Shot in the dark... (10.78 KB, patch) 2015-11-20 12:18 PST, Brady Eidson	no flags	Details Formatted Diff Diff
Patch v3 (10.70 KB, patch) 2015-11-20 13:08 PST, Brady Eidson	sam: review-	Details Formatted Diff Diff
Patch v4 (7.78 KB, patch) 2015-11-20 13:37 PST, Brady Eidson	no flags	Details Formatted Diff Diff
Patch v5 (7.78 KB, patch) 2015-11-20 13:41 PST, Brady Eidson	sam: review+	Details Formatted Diff Diff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.

Brady Eidson

Comment 1 2015-11-19 21:54:53 PST

This will require a custom binding.

Brady Eidson

Comment 2 2015-11-20 11:16:11 PST

Created attachment 265973 [details] Patch v1

Brady Eidson

Comment 3 2015-11-20 11:32:40 PST

These build failures are linker errors on finding stuff for jsNull(). From the mac build: Undefined symbols for architecture x86_64: "__ZN3JSC7JSValueC1ENS0_9JSNullTagE", referenced from: __ZNK7WebCore23JSIDBVersionChangeEvent10newVersionERN3JSC9ExecStateE in JSIDBVersionChangeEventCustom.o "__ZN3JSC7JSValueC1Ey", referenced from: __ZNK7WebCore23JSIDBVersionChangeEvent10oldVersionERN3JSC9ExecStateE in JSIDBVersionChangeEventCustom.o __ZNK7WebCore23JSIDBVersionChangeEvent10newVersionERN3JSC9ExecStateE in JSIDBVersionChangeEventCustom.o ld: symbol(s) not found for architecture x86_64 From EFL: WebCore::JSIDBVersionChangeEvent::newVersion(JSC::ExecState&) const: error: undefined reference to 'JSC::JSValue::JSValue(JSC::JSValue::JSNullTag)' I'm confused by these because: 1 - This patch builds fine for me locally on Mac. 2 - Plenty of other custom bindings use "jsNull()" directly.

Brady Eidson

Comment 4 2015-11-20 11:37:36 PST

mac-debug built fine. The others didn't. How is this a release vs debug issue? =/

Brady Eidson

Comment 5 2015-11-20 12:18:03 PST

Created attachment 265978 [details] Patch v2 - Shot in the dark...

WebKit Commit Bot

Comment 6 2015-11-20 12:19:59 PST

Attachment 265978 [details] did not pass style-queue: ERROR: Source/WebCore/bindings/js/JSIDBVersionChangeEventCustom.cpp:30: You should not add a blank line before implementation file's own header. [build/include_order] [4] Total errors found: 1 in 8 files If any of these errors are false positives, please file a bug against check-webkit-style.

Brady Eidson

Comment 7 2015-11-20 13:01:46 PST

This is definitely a debug vs release issue, as I can reproduce the linker error with a local release build. *WHY*? No friggin' clue.

Brady Eidson

Comment 8 2015-11-20 13:08:30 PST

Created attachment 265982 [details] Patch v3

Brady Eidson

Comment 9 2015-11-20 13:08:51 PST

Some debug-vs-release build difference in which JSValue functions come inlined or not. *sigh* Fixed!

Sam Weinig

Comment 10 2015-11-20 13:22:00 PST

Comment on attachment 265982 [details] Patch v3 View in context: https://bugs.webkit.org/attachment.cgi?id=265982&action=review > Source/WebCore/ChangeLog:4 > + Modern IDB: In the VersionChangeEvent for delete database calls, oldVersion should be null instead of 0. > + https://bugs.webkit.org/show_bug.cgi?id=151481 This title does not match what the patch does. The patch changes the behavior of newVersion, not oldVersion. > Source/WebCore/Modules/indexeddb/IDBVersionChangeEvent.idl:30 > + [Custom] readonly attribute unsigned long long oldVersion; No need for this to be custom. > Source/WebCore/Modules/indexeddb/IDBVersionChangeEvent.idl:31 > + [Custom] readonly attribute unsigned long long newVersion; Can this use the ? syntax instead of using a custom binding?

Brady Eidson

Comment 11 2015-11-20 13:23:44 PST

Patch was right, title was wrong. Trying the optional attribute in bindings right now.

Brady Eidson

Comment 12 2015-11-20 13:37:27 PST

Created attachment 265991 [details] Patch v4

Brady Eidson

Comment 13 2015-11-20 13:41:22 PST

Created attachment 265992 [details] Patch v5

Brady Eidson

Comment 14 2015-11-20 14:15:47 PST

https://trac.webkit.org/changeset/192698

Note You need to log in before you can comment on or make changes to this bug.