Bug 151786

Summary: Reduce size of ScriptElement
Product: WebKit Reporter: Alex Christensen <achristensen>
Component: New BugsAssignee: Alex Christensen <achristensen>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, commit-queue, esprehn+autocc, kangil.han, kling
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Alex Christensen
Reported 2015-12-02 18:26:40 PST
Reduce size of ScriptElement
Attachments
Patch (3.73 KB, patch)
2015-12-02 18:31 PST, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Patch (3.69 KB, patch)
2015-12-02 19:18 PST, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Alex Christensen
Comment 1 2015-12-02 18:31:46 PST
Created attachment 266493 [details] Patch
Alex Christensen
Comment 2 2015-12-02 18:36:37 PST
This reduces the sizeof(ScriptElement) from 168 to 56 bytes, like it was before https://bugs.webkit.org/show_bug.cgi?id=151649
Andreas Kling
Comment 3 2015-12-02 18:39:52 PST
Comment on attachment 266493 [details] Patch r=me
Andreas Kling
Comment 4 2015-12-02 18:52:05 PST
Maybe we could use callOnMainThread() with a captured RefPtr<ScriptElement> to keep it alive here? Then we'd shrink the object even more :)
Alex Christensen
Comment 5 2015-12-02 19:18:05 PST
Created attachment 266499 [details] Patch
WebKit Commit Bot
Comment 6 2015-12-02 19:29:38 PST
Comment on attachment 266499 [details] Patch Clearing flags on attachment: 266499 Committed r192989: <http://trac.webkit.org/changeset/192989>
WebKit Commit Bot
Comment 7 2015-12-02 19:29:43 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.