Bug 152105

Summary: FTL B3 should be able to run quicksort asm.js test
Product: WebKit Reporter: Filip Pizlo <fpizlo>
Component: JavaScriptCoreAssignee: Filip Pizlo <fpizlo>
Status: RESOLVED FIXED    
Severity: Normal CC: barraclough, benjamin, commit-queue, ggaren, keith_miller, mark.lam, mhahnenb, msaboff, nrotem, oliver, ossy, saam, sam
Priority: P2    
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 150279    
Attachments:
Description Flags
the patch
none
Patch none

Filip Pizlo
Reported 2015-12-09 21:37:58 PST
Patch forthcoming.
Attachments
the patch (34.89 KB, patch)
2015-12-09 22:11 PST, Filip Pizlo 		no flags
DetailsFormatted DiffDiff
Patch (23.15 KB, patch)
2015-12-10 17:08 PST, Benjamin Poulain 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Filip Pizlo
Comment 1 2015-12-09 22:11:34 PST
Created attachment 267070 [details] the patch
WebKit Commit Bot
Comment 2 2015-12-10 00:18:27 PST
Attachment 267070 [details] did not pass style-queue: ERROR: Source/JavaScriptCore/ftl/FTLB3Output.h:215: The parameter name "value" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/JavaScriptCore/ftl/FTLB3Output.h:215: The parameter name "pointer" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/JavaScriptCore/ftl/FTLB3Output.h:216: The parameter name "value" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/JavaScriptCore/ftl/FTLB3Output.h:216: The parameter name "pointer" adds no information, so it should be removed. [readability/parameter_name] [5] Total errors found: 4 in 18 files If any of these errors are false positives, please file a bug against check-webkit-style.
Filip Pizlo
Comment 3 2015-12-10 09:20:55 PST
*** Bug 152125 has been marked as a duplicate of this bug. ***
Geoffrey Garen
Comment 4 2015-12-10 15:36:37 PST
Comment on attachment 267070 [details] the patch View in context: https://bugs.webkit.org/attachment.cgi?id=267070&action=review r=me > Source/JavaScriptCore/ChangeLog:16 > + - Implemented Mod in B3 and wrote tests. I wonder how this compares to https://bugs.webkit.org/show_bug.cgi?id=152110.
Benjamin Poulain
Comment 5 2015-12-10 15:44:49 PST
Comment on attachment 267070 [details] the patch Oops, wrong bug.
Benjamin Poulain
Comment 6 2015-12-10 17:08:19 PST
Created attachment 267140 [details] Patch
Benjamin Poulain
Comment 7 2015-12-10 17:08:52 PST
Same patch, rebaselined.
Filip Pizlo
Comment 8 2015-12-10 20:04:19 PST
Landed in http://trac.webkit.org/changeset/193943
Note You need to log in before you can comment on or make changes to this bug.