Bug 152222

Summary: FTLB3Output should maintain good block order like the LLVM one does
Product: WebKit Reporter: Filip Pizlo <fpizlo>
Component: JavaScriptCoreAssignee: Filip Pizlo <fpizlo>
Status: RESOLVED FIXED    
Severity: Normal CC: barraclough, benjamin, commit-queue, ggaren, keith_miller, mark.lam, mhahnenb, msaboff, oliver, saam, sam
Priority: P2    
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 150279    
Attachments:
Description Flags
work in progress
none
the patch
ggaren: review+, buildbot: commit-queue-
Archive of layout-test-results from ews117 for mac-yosemite none

Filip Pizlo
Reported 2015-12-12 22:13:50 PST
...
Attachments
work in progress (16.03 KB, patch)
2016-01-25 19:30 PST, Filip Pizlo 		no flags
DetailsFormatted DiffDiff
the patch (21.95 KB, patch)
2016-01-25 23:01 PST, Filip Pizlo 		ggaren: review+
buildbot: commit-queue-
DetailsFormatted DiffDiff
Archive of layout-test-results from ews117 for mac-yosemite (1.09 MB, application/zip)
2016-01-25 23:59 PST, Build Bot 		no flags
Details
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Filip Pizlo
Comment 1 2016-01-25 19:30:24 PST
Created attachment 269844 [details] work in progress
Filip Pizlo
Comment 2 2016-01-25 23:01:14 PST
Created attachment 269853 [details] the patch
WebKit Commit Bot
Comment 3 2016-01-25 23:04:04 PST
Attachment 269853 [details] did not pass style-queue: ERROR: Source/JavaScriptCore/disassembler/udis86/udis86_syn-att.c:234: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/JavaScriptCore/disassembler/udis86/udis86_syn-att.c:235: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Total errors found: 2 in 13 files If any of these errors are false positives, please file a bug against check-webkit-style.
Geoffrey Garen
Comment 4 2016-01-25 23:35:56 PST
Comment on attachment 269853 [details] the patch r=me
Filip Pizlo
Comment 5 2016-01-25 23:57:53 PST
Thanks! I have a fix for the debug test failures. It was an incorrect assertion in the linked list code.
Build Bot
Comment 6 2016-01-25 23:59:40 PST
Comment on attachment 269853 [details] the patch Attachment 269853 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/740083 Number of test failures exceeded the failure limit.
Build Bot
Comment 7 2016-01-25 23:59:43 PST
Created attachment 269860 [details] Archive of layout-test-results from ews117 for mac-yosemite The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews117 Port: mac-yosemite Platform: Mac OS X 10.10.5
Filip Pizlo
Comment 8 2016-01-26 00:18:09 PST
Landed in http://trac.webkit.org/changeset/195585
Filip Pizlo
Comment 9 2016-01-26 00:18:26 PST
Landed in http://trac.webkit.org/changeset/195585
Note You need to log in before you can comment on or make changes to this bug.