Bug 153272

Summary: Modern IDB: Add -private.html variants of every storage/indexeddb test that doesn't already have them
Product: WebKit Reporter: Brady Eidson <beidson>
Component: WebCore Misc.Assignee: Brady Eidson <beidson>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, alecflett, buildbot, commit-queue, jsbell, rniwa, sam
Priority: P2    
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 149117    
Attachments:
Description Flags
Working patch
buildbot: commit-queue-
Archive of layout-test-results from ews106 for mac-yosemite-wk2
none
Archive of layout-test-results from ews102 for mac-yosemite
none
Archive of layout-test-results from ews113 for mac-yosemite
none
Patch v1
achristensen: review+, buildbot: commit-queue-
Archive of layout-test-results from ews105 for mac-yosemite-wk2
none
Patch v2 - All the new private tests should be skipped in WK2 (legacy IDB) none

Brady Eidson
Reported 2016-01-19 23:14:15 PST
Modern IDB: Add -private.html variants of every storage/indexeddb test that doesn't already have them The testing infrastructure already handles enabling private browsing on these by virtue of having -private.html in their filenames, so all we need is the .html and -expected.txt files on disk.
Attachments
Working patch (431.30 KB, patch)
2016-01-19 23:17 PST, Brady Eidson 		buildbot: commit-queue-
DetailsFormatted DiffDiff
Archive of layout-test-results from ews106 for mac-yosemite-wk2 (1.13 MB, application/zip)
2016-01-19 23:48 PST, Build Bot 		no flags
Details
Archive of layout-test-results from ews102 for mac-yosemite (1.06 MB, application/zip)
2016-01-19 23:58 PST, Build Bot 		no flags
Details
Archive of layout-test-results from ews113 for mac-yosemite (907.41 KB, application/zip)
2016-01-20 00:25 PST, Build Bot 		no flags
Details
Patch v1 (474.21 KB, patch)
2016-01-20 16:07 PST, Brady Eidson 		achristensen: review+
buildbot: commit-queue-
DetailsFormatted DiffDiff
Archive of layout-test-results from ews105 for mac-yosemite-wk2 (910.85 KB, application/zip)
2016-01-20 16:57 PST, Build Bot 		no flags
Details
Patch v2 - All the new private tests should be skipped in WK2 (legacy IDB) (483.84 KB, patch)
2016-01-20 17:18 PST, Brady Eidson 		no flags
DetailsFormatted DiffDiff
Show Obsolete (5) View All Add attachment proposed patch, testcase, etc.
Brady Eidson
Comment 1 2016-01-19 23:15:02 PST
I've created all of the appropriate files locally, will get a huge patch up once I confirm all tests that run actually pass.
Brady Eidson
Comment 2 2016-01-19 23:17:28 PST
Created attachment 269346 [details] Working patch Not for review yet - Just attaching the working patch in case I need to switch machines
Build Bot
Comment 3 2016-01-19 23:48:31 PST
Comment on attachment 269346 [details] Working patch Attachment 269346 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/715832 Number of test failures exceeded the failure limit.
Build Bot
Comment 4 2016-01-19 23:48:35 PST
Created attachment 269347 [details] Archive of layout-test-results from ews106 for mac-yosemite-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews106 Port: mac-yosemite-wk2 Platform: Mac OS X 10.10.5
Build Bot
Comment 5 2016-01-19 23:58:25 PST
Comment on attachment 269346 [details] Working patch Attachment 269346 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/715846 Number of test failures exceeded the failure limit.
Build Bot
Comment 6 2016-01-19 23:58:29 PST
Created attachment 269348 [details] Archive of layout-test-results from ews102 for mac-yosemite The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews102 Port: mac-yosemite Platform: Mac OS X 10.10.5
Build Bot
Comment 7 2016-01-20 00:25:17 PST
Comment on attachment 269346 [details] Working patch Attachment 269346 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/715892 Number of test failures exceeded the failure limit.
Build Bot
Comment 8 2016-01-20 00:25:23 PST
Created attachment 269349 [details] Archive of layout-test-results from ews113 for mac-yosemite The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews113 Port: mac-yosemite Platform: Mac OS X 10.10.5
Brady Eidson
Comment 9 2016-01-20 16:07:21 PST
Created attachment 269397 [details] Patch v1
Build Bot
Comment 10 2016-01-20 16:56:59 PST
Comment on attachment 269397 [details] Patch v1 Attachment 269397 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/719141 Number of test failures exceeded the failure limit.
Build Bot
Comment 11 2016-01-20 16:57:02 PST
Created attachment 269404 [details] Archive of layout-test-results from ews105 for mac-yosemite-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews105 Port: mac-yosemite-wk2 Platform: Mac OS X 10.10.5
Brady Eidson
Comment 12 2016-01-20 17:18:16 PST
Created attachment 269408 [details] Patch v2 - All the new private tests should be skipped in WK2 (legacy IDB)
WebKit Commit Bot
Comment 13 2016-01-20 18:13:35 PST
Comment on attachment 269408 [details] Patch v2 - All the new private tests should be skipped in WK2 (legacy IDB) Clearing flags on attachment: 269408 Committed r195394: <http://trac.webkit.org/changeset/195394>
Note You need to log in before you can comment on or make changes to this bug.