Bug 153415

Summary: Modern IDB: Implement deleteIndex and getCount for the SQLite backing store
Product: WebKit Reporter: Brady Eidson <beidson>
Component: WebCore Misc.Assignee: Brady Eidson <beidson>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, alecflett, commit-queue, jsbell
Priority: P2    
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 149117, 153021    
Attachments:
Description Flags
Patch v1
darin: review+, buildbot: commit-queue-
Archive of layout-test-results from ews116 for mac-yosemite
none
Patch for landing none

Brady Eidson
Reported 2016-01-24 19:28:57 PST
Modern IDB: Implement deleteIndex and getCount for the SQLite backing store
Attachments
Patch v1 (31.13 KB, patch)
2016-01-24 20:18 PST, Brady Eidson 		darin: review+
buildbot: commit-queue-
DetailsFormatted DiffDiff
Archive of layout-test-results from ews116 for mac-yosemite (782.79 KB, application/zip)
2016-01-24 21:27 PST, Build Bot 		no flags
Details
Patch for landing (30.98 KB, patch)
2016-01-24 22:25 PST, Brady Eidson 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Brady Eidson
Comment 1 2016-01-24 20:18:29 PST
Created attachment 269720 [details] Patch v1
Darin Adler
Comment 2 2016-01-24 21:14:08 PST
Comment on attachment 269720 [details] Patch v1 View in context: https://bugs.webkit.org/attachment.cgi?id=269720&action=review > Source/WebCore/Modules/indexeddb/server/SQLiteIDBCursor.cpp:88 > + if (!m_indexID) > + m_indexID = IDBIndexMetadata::InvalidId; Could do this with ? : in the initializer. , m_indexID(m_indexID ? m_indexID : IDBIndexMetadata::InvalidId)
Build Bot
Comment 3 2016-01-24 21:27:47 PST
Comment on attachment 269720 [details] Patch v1 Attachment 269720 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/735392 New failing tests: imported/w3c/web-platform-tests/streams-api/readable-streams/garbage-collection.html
Build Bot
Comment 4 2016-01-24 21:27:49 PST
Created attachment 269722 [details] Archive of layout-test-results from ews116 for mac-yosemite The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews116 Port: mac-yosemite Platform: Mac OS X 10.10.5
Brady Eidson
Comment 5 2016-01-24 21:48:29 PST
(In reply to comment #3) > Comment on attachment 269720 [details] > Patch v1 > > Attachment 269720 [details] did not pass mac-debug-ews (mac): > Output: http://webkit-queues.webkit.org/results/735392 > > New failing tests: > imported/w3c/web-platform-tests/streams-api/readable-streams/garbage- > collection.html Just knowing a test named this failed, it's unclear how this patch caused it. Looking into it...
Brady Eidson
Comment 6 2016-01-24 22:25:58 PST
Created attachment 269725 [details] Patch for landing Perhaps EWS hiccuped or something...? Made the change Darin suggested and re-uploading for CQ. Running tests locally and will let EWS run as well.
Brady Eidson
Comment 7 2016-01-24 22:28:01 PST
The test that crashed was doing some JSGlobalObject task on a worker thread, but all of the IndexedDB tests that use workers are currently disabled. I don't see how this was at fault.
Brady Eidson
Comment 8 2016-01-24 22:54:46 PST
Definitely did not see this locally over two full test runs.
WebKit Commit Bot
Comment 9 2016-01-24 23:55:27 PST
Comment on attachment 269725 [details] Patch for landing Clearing flags on attachment: 269725 Committed r195527: <http://trac.webkit.org/changeset/195527>
Note You need to log in before you can comment on or make changes to this bug.