Bug 153534

Summary:

Rename HTMLSlotElement.getDistributedNodes to getAssignedNodes

Product:

WebKit

Reporter:

Ryosuke Niwa <rniwa>

Component:

DOM

Assignee:

Ryosuke Niwa <rniwa>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

buildbot, cdumez, commit-queue, esprehn+autocc, gyuyoung.kim, kling, koivisto, kondapallykalyan, rniwa

Priority:

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

148695

Attachments:

Description	Flags
Renames the method	none
Archive of layout-test-results from ews101 for mac-yosemite	none
Archive of layout-test-results from ews105 for mac-yosemite-wk2	none
Archive of layout-test-results from ews115 for mac-yosemite	none
rebaselined the test	koivisto: review+

Ryosuke Niwa

Reported 2016-01-26 21:50:28 PST

The shadow DOM API spec has been updated not to only assign Element and Text nodes to a slot element in https://github.com/w3c/webcomponents/commit/f986bf803e6bf092a2f23ea08359abd8722f9aac Update our implementation to reflect that.

Attachments
Renames the method (16.94 KB, patch) 2016-01-26 22:45 PST, Ryosuke Niwa	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews101 for mac-yosemite (742.40 KB, application/zip) 2016-01-26 23:36 PST, Build Bot	no flags	Details
Archive of layout-test-results from ews105 for mac-yosemite-wk2 (934.42 KB, application/zip) 2016-01-26 23:40 PST, Build Bot	no flags	Details
Archive of layout-test-results from ews115 for mac-yosemite (794.98 KB, application/zip) 2016-01-26 23:51 PST, Build Bot	no flags	Details
rebaselined the test (18.15 KB, patch) 2016-01-27 11:21 PST, Ryosuke Niwa	koivisto: review+	Details Formatted Diff Diff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.

Ryosuke Niwa

Comment 1 2016-01-26 22:45:22 PST

Created attachment 269983 [details] Renames the method

Build Bot

Comment 2 2016-01-26 23:36:44 PST

Comment on attachment 269983 [details] Renames the method Attachment 269983 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/744465 New failing tests: fast/shadow-dom/HTMLSlotElement-interface.html

Build Bot

Comment 3 2016-01-26 23:36:47 PST

Created attachment 269985 [details] Archive of layout-test-results from ews101 for mac-yosemite The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews101 Port: mac-yosemite Platform: Mac OS X 10.10.5

Build Bot

Comment 4 2016-01-26 23:40:45 PST

Comment on attachment 269983 [details] Renames the method Attachment 269983 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/744473 New failing tests: fast/shadow-dom/HTMLSlotElement-interface.html

Build Bot

Comment 5 2016-01-26 23:40:48 PST

Created attachment 269986 [details] Archive of layout-test-results from ews105 for mac-yosemite-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews105 Port: mac-yosemite-wk2 Platform: Mac OS X 10.10.5

Build Bot

Comment 6 2016-01-26 23:51:27 PST

Comment on attachment 269983 [details] Renames the method Attachment 269983 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/744467 New failing tests: fast/shadow-dom/HTMLSlotElement-interface.html

Build Bot

Comment 7 2016-01-26 23:51:30 PST

Created attachment 269988 [details] Archive of layout-test-results from ews115 for mac-yosemite The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews115 Port: mac-yosemite Platform: Mac OS X 10.10.5

Ryosuke Niwa

Comment 8 2016-01-27 11:21:11 PST

Created attachment 270013 [details] rebaselined the test

Ryosuke Niwa

Comment 9 2016-01-27 12:08:58 PST

Committed r195681: <http://trac.webkit.org/changeset/195681>

Note You need to log in before you can comment on or make changes to this bug.