Bug 154356

Summary: Modern IDB: More Encoder/Decoder/Messaging scaffolding for WK2 IPC
Product: WebKit Reporter: Brady Eidson <beidson>
Component: WebCore Misc.Assignee: Brady Eidson <beidson>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, alecflett, commit-queue, jsbell
Priority: P2    
Version: Safari 9   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 149117, 153808    
Attachments:
Description Flags
Patch v1
achristensen: review+, beidson: commit-queue-
Patch for linux EWS none

Brady Eidson
Reported 2016-02-17 13:33:02 PST
Modern IDB: More Encoder/Decoder/Messaging scaffolding for WK2 IPC
Attachments
Patch v1 (17.90 KB, patch)
2016-02-17 13:39 PST, Brady Eidson 		achristensen: review+
beidson: commit-queue-
DetailsFormatted DiffDiff
Patch for linux EWS (18.73 KB, patch)
2016-02-17 14:48 PST, Brady Eidson 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Brady Eidson
Comment 1 2016-02-17 13:39:54 PST
Created attachment 271584 [details] Patch v1
Alex Christensen
Comment 2 2016-02-17 13:46:20 PST
Comment on attachment 271584 [details] Patch v1 View in context: https://bugs.webkit.org/attachment.cgi?id=271584&action=review > Source/WebCore/Modules/indexeddb/shared/IDBDatabaseInfo.h:62 > + WEBCORE_EXPORT IDBDatabaseInfo(); I think this should go with the other constructor declaration. > Source/WebKit2/WebProcess/Databases/IndexedDB/WebIDBConnectionToServer.messages.in:41 > + intentional space?
Brady Eidson
Comment 3 2016-02-17 13:57:50 PST
(In reply to comment #2) > Comment on attachment 271584 [details] > Patch v1 > > View in context: > https://bugs.webkit.org/attachment.cgi?id=271584&action=review > > > Source/WebCore/Modules/indexeddb/shared/IDBDatabaseInfo.h:62 > > + WEBCORE_EXPORT IDBDatabaseInfo(); > > I think this should go with the other constructor declaration. I've been trying to make it clear - or at least suggest - that these default constructors are only for the sake of encoder/decoder (They didn't exist before today) > > > Source/WebKit2/WebProcess/Databases/IndexedDB/WebIDBConnectionToServer.messages.in:41 > > + > > intentional space? Yes.
Brady Eidson
Comment 4 2016-02-17 14:48:35 PST
Created attachment 271595 [details] Patch for linux EWS
Brady Eidson
Comment 5 2016-02-17 15:24:23 PST
GTK is broken for other reasons... I'm landing now.
Brady Eidson
Comment 6 2016-02-17 15:25:33 PST
http://trac.webkit.org/changeset/196725
Note You need to log in before you can comment on or make changes to this bug.