Bug 154498

Summary: Enhance logging: Add "always on" macros
Product: WebKit Reporter: Keith Rollin <krollin>
Component: Web Template FrameworkAssignee: Keith Rollin <krollin>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, benjamin, cdumez, cmarcelo, commit-queue, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 154499    
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Archive of layout-test-results from ews112 for mac-yosemite
none
Patch none

Keith Rollin
Reported 2016-02-20 11:49:46 PST
Add macros to Assertions.h/.cpp to be used for "always on" logging. This is logging that we want in both debug and release code, the former for development purposes, the latter so that we can capture information to help diagnose issues that occur on customers' systems.
Attachments
Patch (deleted)
2016-02-23 13:57 PST, Keith Rollin 		no flags
Details
Patch (3.69 KB, patch)
2016-02-26 10:45 PST, Keith Rollin 		no flags
DetailsFormatted DiffDiff
Patch (3.85 KB, patch)
2016-02-26 13:02 PST, Keith Rollin 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from ews112 for mac-yosemite (853.61 KB, application/zip)
2016-02-26 14:20 PST, Build Bot 		no flags
Details
Patch (3.85 KB, patch)
2016-02-26 14:33 PST, Keith Rollin 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2016-02-20 11:59:57 PST
<rdar://problem/24757759>
Keith Rollin
Comment 2 2016-02-23 13:57:53 PST
Created attachment 272051 [details] Patch
David Kilzer (:ddkilzer)
Comment 3 2016-02-24 16:30:21 PST
The content of attachment 272051 [details] has been deleted by David Kilzer (:ddkilzer) <ddkilzer@webkit.org> who provided the following reason: Yes The token used to delete this attachment was generated at 2016-02-24 16:30:04 PST.
Keith Rollin
Comment 4 2016-02-26 10:45:51 PST
Created attachment 272338 [details] Patch
Chris Dumez
Comment 5 2016-02-26 10:50:12 PST
Comment on attachment 272338 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=272338&action=review > Source/WTF/wtf/Assertions.h:388 > +#define LOG_ALWAYS_ERROR(format, ...) WTFLogAlways(format, ##__VA_ARGS__) Shouldn't this do something similar to LOG_ERROR?
Keith Rollin
Comment 6 2016-02-26 13:02:41 PST
Created attachment 272361 [details] Patch
Build Bot
Comment 7 2016-02-26 14:20:44 PST
Comment on attachment 272361 [details] Patch Attachment 272361 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/887355 New failing tests: storage/indexeddb/odd-strings-private.html
Build Bot
Comment 8 2016-02-26 14:20:47 PST
Created attachment 272372 [details] Archive of layout-test-results from ews112 for mac-yosemite The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews112 Port: mac-yosemite Platform: Mac OS X 10.10.5
Chris Dumez
Comment 9 2016-02-26 14:22:40 PST
Comment on attachment 272361 [details] Patch r=me
WebKit Commit Bot
Comment 10 2016-02-26 14:24:29 PST
Comment on attachment 272361 [details] Patch Rejecting attachment 272361 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'validate-changelog', '--check-oops', '--non-interactive', 272361, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit /Volumes/Data/EWS/WebKit/Source/WTF/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive). Full output: http://webkit-queues.webkit.org/results/887543
Chris Dumez
Comment 11 2016-02-26 14:26:47 PST
Comment on attachment 272361 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=272361&action=review > Source/WTF/ChangeLog:7 > + Reviewed by NOBODY (OOPS). Isn't supposed to be (OOPS!)??
Keith Rollin
Comment 12 2016-02-26 14:33:08 PST
Created attachment 272373 [details] Patch
WebKit Commit Bot
Comment 13 2016-02-26 15:33:39 PST
Comment on attachment 272373 [details] Patch Clearing flags on attachment: 272373 Committed r197214: <http://trac.webkit.org/changeset/197214>
WebKit Commit Bot
Comment 14 2016-02-26 15:33:44 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.