Bug 154911

Summary: [css-grid] Simplify method to resolve auto-placed items
Product: WebKit Reporter: Manuel Rego Casasnovas <rego>
Component: Layout and RenderingAssignee: Manuel Rego Casasnovas <rego>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, esprehn+autocc, glenn, jfernandez, kondapallykalyan, rego, simon.fraser, svillar
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 153488    
Attachments:
Description Flags
Patch
none
Patch none

Manuel Rego Casasnovas
Reported 2016-03-02 00:20:14 PST
Port this patch from Blink: https://codereview.chromium.org/1496863004/
Attachments
Patch (11.99 KB, patch)
2016-03-02 00:21 PST, Manuel Rego Casasnovas 		no flags
DetailsFormatted DiffDiff
Patch (11.96 KB, patch)
2016-03-02 01:03 PST, Manuel Rego Casasnovas 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Manuel Rego Casasnovas
Comment 1 2016-03-02 00:21:27 PST
Created attachment 272641 [details] Patch
Manuel Rego Casasnovas
Comment 2 2016-03-02 01:03:44 PST
Created attachment 272644 [details] Patch
Sergio Villar Senin
Comment 3 2016-03-03 01:12:04 PST
Comment on attachment 272644 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=272644&action=review > Source/WebCore/rendering/style/GridResolvedPosition.cpp:242 > + return position.spanPosition(); We should change the name of this method at some point because it isn't clear that it's returning the span (spanPosition looks like a type of position).
WebKit Commit Bot
Comment 4 2016-03-03 02:23:28 PST
Comment on attachment 272644 [details] Patch Clearing flags on attachment: 272644 Committed r197501: <http://trac.webkit.org/changeset/197501>
WebKit Commit Bot
Comment 5 2016-03-03 02:23:31 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.