Bug 157225

Summary: Rename getAssignedNodes to assignedNodes and support flattened option
Product: WebKit Reporter: Ryosuke Niwa <rniwa>
Component: DOMAssignee: Ryosuke Niwa <rniwa>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, commit-queue, esprehn+autocc, gyuyoung.kim, koivisto, kondapallykalyan, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 148695    
Attachments:
Description Flags
Patch koivisto: review+

Ryosuke Niwa
Reported 2016-04-29 20:00:05 PDT
Update HTMLSlotElement.prototype.getAssignedNodes to match the latest spec.
Attachments
Patch (27.84 KB, patch)
2016-04-29 20:24 PDT, Ryosuke Niwa 		koivisto: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Ryosuke Niwa
Comment 1 2016-04-29 20:24:28 PDT
Created attachment 277787 [details] Patch
Antti Koivisto
Comment 2 2016-04-29 21:01:19 PDT
Comment on attachment 277787 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=277787&action=review > Source/WebCore/html/HTMLSlotElement.cpp:110 > + } else > + nodes.append(node); I usually use continue rather than dangling else like this.
Ryosuke Niwa
Comment 3 2016-04-29 21:18:27 PDT
Committed r200285: <http://trac.webkit.org/changeset/200285>
Radar WebKit Bug Importer
Comment 4 2016-04-29 23:07:50 PDT
<rdar://problem/26022326>
Note You need to log in before you can comment on or make changes to this bug.