Bug 157823

Summary:

Modern IDB: Make TestRunner.clearAllDatabases also delete IndexedDB databases (once doing so is supported)

Product:

WebKit

Reporter:

Brady Eidson <beidson>

Component:

WebKit Misc.

Assignee:

Brady Eidson <beidson>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

achristensen, alecflett, commit-queue, gyuyoung.kim, jsbell

Priority:

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

149117, 157626

Attachments:

Description	Flags
Patch v1	achristensen: review+
Patch for ES	none
Patch for EWS + landing	none

Brady Eidson

Reported 2016-05-17 17:16:39 PDT

Modern IDB: Make TestRunner.clearAllDatabases also delete IndexedDB databases (once doing so is supported in WebCore) Landing this separately is an attempt to make the work in https://bugs.webkit.org/show_bug.cgi?id=157626 more manageable to polish and review.

Attachments
Patch v1 (12.86 KB, patch) 2016-05-17 17:20 PDT, Brady Eidson	achristensen: review+	Details Formatted Diff Diff
Patch for ES (13.82 KB, application/octet-stream) 2016-05-18 08:52 PDT, Brady Eidson	no flags	Details
Patch for EWS + landing (13.82 KB, patch) 2016-05-18 08:52 PDT, Brady Eidson	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Brady Eidson

Comment 1 2016-05-17 17:20:36 PDT

Created attachment 279188 [details] Patch v1

WebKit Commit Bot

Comment 2 2016-05-17 17:22:57 PDT

Attachment 279188 [details] did not pass style-queue: ERROR: Source/WebCore/Modules/indexeddb/server/IDBServer.h:99: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/Modules/indexeddb/server/IDBServer.cpp:471: Extra space before ( in function call [whitespace/parens] [4] Total errors found: 2 in 17 files If any of these errors are false positives, please file a bug against check-webkit-style.

Alex Christensen

Comment 3 2016-05-17 23:05:25 PDT

Comment on attachment 279188 [details] Patch v1 View in context: https://bugs.webkit.org/attachment.cgi?id=279188&action=review > Source/WebKit2/UIProcess/API/C/WKWebsiteDataStoreRef.cpp:62 > +void WKWebsiteDataStoreRemoveAllIndexedDatabases(WKWebsiteDataStoreRef dataStoreRef) > +{ > + OptionSet<WebKit::WebsiteDataType> dataTypes = WebKit::WebsiteDataType::IndexedDBDatabases; > + return WebKit::toImpl(dataStoreRef)->websiteDataStore().removeData(dataTypes, std::chrono::system_clock::time_point::min(), [] { }); > +} return??? If I wrote my own c++ compiler, this would be a compiler error. > Tools/WebKitTestRunner/InjectedBundle/TestRunner.cpp:259 > + WKBundlePostSynchronousMessage(InjectedBundle::singleton().bundle(), messageName.get(), messageBody.get(), 0); nullptr > Tools/WebKitTestRunner/TestInvocation.cpp:719 > + WKWebsiteDataStoreRemoveAllIndexedDatabases(WKContextGetWebsiteDataStore(TestController::singleton().context())); EFL doesn't like this. I'm not sure why. Everything seems correct. Maybe they're including an old version of the header without the change. WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle(OpaqueWKString const*, void const*): error: undefined reference to 'WKWebsiteDataStoreRemoveAllIndexedDatabases'

Brady Eidson

Comment 4 2016-05-18 08:50:13 PDT

(In reply to comment #3) > Comment on attachment 279188 [details] > Patch v1 > > View in context: > https://bugs.webkit.org/attachment.cgi?id=279188&action=review > > > Source/WebKit2/UIProcess/API/C/WKWebsiteDataStoreRef.cpp:62 > > +void WKWebsiteDataStoreRemoveAllIndexedDatabases(WKWebsiteDataStoreRef dataStoreRef) > > +{ > > + OptionSet<WebKit::WebsiteDataType> dataTypes = WebKit::WebsiteDataType::IndexedDBDatabases; > > + return WebKit::toImpl(dataStoreRef)->websiteDataStore().removeData(dataTypes, std::chrono::system_clock::time_point::min(), [] { }); > > +} > > return??? If I wrote my own c++ compiler, this would be a compiler error. "void" is a valid return in a void function. :) (I copied this line from somewhere else before editing it) > > Tools/WebKitTestRunner/TestInvocation.cpp:719 > > + WKWebsiteDataStoreRemoveAllIndexedDatabases(WKContextGetWebsiteDataStore(TestController::singleton().context())); > > EFL doesn't like this. I'm not sure why. Everything seems correct. Maybe > they're including an old version of the header without the change. > WTR::TestInvocation:: > didReceiveSynchronousMessageFromInjectedBundle(OpaqueWKString const*, void > const*): error: undefined reference to > 'WKWebsiteDataStoreRemoveAllIndexedDatabases' They never compiled WKWebsiteDataStoreRef. They will now.

Brady Eidson

Comment 5 2016-05-18 08:52:34 PDT

Created attachment 279255 [details] Patch for ES

Brady Eidson

Comment 6 2016-05-18 08:52:54 PDT

Created attachment 279256 [details] Patch for EWS + landing

WebKit Commit Bot

Comment 7 2016-05-18 08:53:51 PDT

Attachment 279256 [details] did not pass style-queue: ERROR: Source/WebCore/Modules/indexeddb/server/IDBServer.h:99: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/Modules/indexeddb/server/IDBServer.cpp:471: Extra space before ( in function call [whitespace/parens] [4] Total errors found: 2 in 18 files If any of these errors are false positives, please file a bug against check-webkit-style.

WebKit Commit Bot

Comment 8 2016-05-18 09:29:32 PDT

Comment on attachment 279256 [details] Patch for EWS + landing Clearing flags on attachment: 279256 Committed r201081: <http://trac.webkit.org/changeset/201081>

Note You need to log in before you can comment on or make changes to this bug.