Bug 158501

Summary: LayoutTest storage/indexeddb/modern/handle-user-delete.html is a flaky failure
Product: WebKit Reporter: Ryan Haddad <ryanhaddad>
Component: New BugsAssignee: Brady Eidson <beidson>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, alecflett, beidson, commit-queue, jsbell
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 154968    
Attachments:
Description Flags
Patch none

Ryan Haddad
Reported 2016-06-07 17:11:38 PDT
LayoutTest storage/indexeddb/modern/handle-user-delete.html is a flaky failure <https://build.webkit.org/results/Apple%20Yosemite%20Release%20WK2%20(Tests)/r201772%20(15103)/results.html> <http://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=storage%2Findexeddb%2Fmodern%2Fhandle-user-delete.html> --- /Volumes/Data/slave/yosemite-release-tests-wk2/build/layout-test-results/storage/indexeddb/modern/handle-user-delete-expected.txt +++ /Volumes/Data/slave/yosemite-release-tests-wk2/build/layout-test-results/storage/indexeddb/modern/handle-user-delete-actual.txt @@ -10,7 +10,6 @@ Initial upgrade needed: Old version - 0 New version - 1 Started two spinning requests Requested clearAllDatabases -Initial upgrade versionchange transaction aborted: [object DOMError] [PASS] Both requests hit a failure condition (Received onerror or failed to start a new request because the transaction was aborted) [PASS] Database received correct error. PASS successfullyParsed is true
Attachments
Patch (3.21 KB, patch)
2016-06-09 09:57 PDT, Brady Eidson 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Brady Eidson
Comment 1 2016-06-07 23:04:07 PDT
Yup, that line is both irrelevant to the test and definitely timing dependent. Will remove.
Brady Eidson
Comment 2 2016-06-09 09:20:53 PDT
(In reply to comment #1) > Yup, that line is both irrelevant to the test and definitely timing > dependent. Actually, no - It's not irrelevant. But it *is* timing dependent. I'm updating the test to handle that.
Brady Eidson
Comment 3 2016-06-09 09:57:04 PDT
Created attachment 280925 [details] Patch
Darin Adler
Comment 4 2016-06-09 10:07:29 PDT
Comment on attachment 280925 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=280925&action=review > LayoutTests/storage/indexeddb/modern/resources/handle-user-delete.js:87 > + maybeFinish(); This is indented four spaces too much.
WebKit Commit Bot
Comment 5 2016-06-09 10:29:38 PDT
Comment on attachment 280925 [details] Patch Clearing flags on attachment: 280925 Committed r201871: <http://trac.webkit.org/changeset/201871>
WebKit Commit Bot
Comment 6 2016-06-09 10:29:42 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.