Bug 158686

Summary: [GTK] Enabling Shadow DOM by default
Product: WebKit Reporter: Romain Bellessort <romain.wkt>
Component: WebKitGTKAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: bugs-noreply, cgarcia, commit-queue, dbates, mcatanzaro, rniwa
Priority: P2    
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 148695    
Attachments:
Description Flags
Patch
none
Patch none

Romain Bellessort
Reported 2016-06-13 02:29:02 PDT
Following https://bugs.webkit.org/show_bug.cgi?id=153772, enabling Shadow DOM by default in GTK+ seems possible.
Attachments
Patch (3.45 KB, patch)
2016-06-13 05:33 PDT, Romain Bellessort 		no flags
DetailsFormatted DiffDiff
Patch (4.85 KB, patch)
2016-06-13 06:29 PDT, Romain Bellessort 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Romain Bellessort
Comment 1 2016-06-13 05:33:12 PDT
Created attachment 281168 [details] Patch
Carlos Garcia Campos
Comment 2 2016-06-13 05:41:44 PDT
LGTM, you should also update Source/cmake/OptionsGTK.cmake to enable it in production builds (or do you want to enable it only for development builds for now?). Why didn't you ask for review? is this supposed to be a WIP patch?
Romain Bellessort
Comment 3 2016-06-13 06:27:56 PDT
(In reply to comment #2) > LGTM, you should also update Source/cmake/OptionsGTK.cmake to enable it in > production builds (or do you want to enable it only for development builds > for now?). Thanks, I will upload another patch that addresses OptionsGTK.cmake (I was not sure about the impact so I went for the smallest change first). > Why didn't you ask for review? is this supposed to be a WIP patch? As this is my first patch I wanted to check that everything was ok prior to asking for review, but I will directly ask for review with the updated patch. Thanks again.
Romain Bellessort
Comment 4 2016-06-13 06:29:11 PDT
Created attachment 281171 [details] Patch
Carlos Garcia Campos
Comment 5 2016-06-13 06:46:13 PDT
Comment on attachment 281171 [details] Patch Thanks!
WebKit Commit Bot
Comment 6 2016-06-13 07:08:43 PDT
Comment on attachment 281171 [details] Patch Clearing flags on attachment: 281171 Committed r201989: <http://trac.webkit.org/changeset/201989>
WebKit Commit Bot
Comment 7 2016-06-13 07:08:47 PDT
All reviewed patches have been landed. Closing bug.
Michael Catanzaro
Comment 8 2016-06-13 08:46:18 PDT
Ryosuke, do you agree? I don't think it makes sense to enable it in OptionsGTK.cmake; we should probably match what other ports are doing, since there is no platform-specific implementation here, correct? If it's ready for all ports, it should be changed in WebKitFeatures.cmake, not OptionsGTK.cmake.
Ryosuke Niwa
Comment 9 2016-06-13 12:24:13 PDT
Yeah, we should enable it on all platforms. In fact, we should probably just get rid of the build flag altogether now since we have a runtime flag.
Note You need to log in before you can comment on or make changes to this bug.