Bug 159056

Summary: Implement redirect support post CORS-preflight
Product: WebKit Reporter: Anne van Kesteren <annevk>
Component: WebCore Misc.Assignee: youenn fablet <youennf>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, ap, cdumez, commit-queue, dpaddock, japhet, mike, youennf
Priority: P2    
Version: Safari Technology Preview   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=112471
Bug Depends on:    
Bug Blocks: 151937    
Attachments:
Description Flags
Patch none

Anne van Kesteren
Reported 2016-06-23 07:47:23 PDT
A CORS-preflight can be followed by a redirect these days. See also: * https://bugzilla.mozilla.org/show_bug.cgi?id=918767 * https://bugs.chromium.org/p/chromium/issues/detail?id=580796 * https://github.com/w3c/web-platform-tests/issues/2520
Attachments
Patch (22.77 KB, patch)
2016-08-21 14:07 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
youenn fablet
Comment 1 2016-08-21 14:07:38 PDT
Created attachment 286571 [details] Patch
Alex Christensen
Comment 2 2016-08-21 22:25:06 PDT
Should this be r?
youenn fablet
Comment 3 2016-08-22 06:22:30 PDT
Comment on attachment 286571 [details] Patch There is no test checking valid XHR preflighting after cross-origin redirections. But the fetch API tests cover successful (and failing) preflighting after cross-origin redirections. Since the code between fetch and XHR is common, this is probably sufficient. Marking patch as r?.
youenn fablet
Comment 4 2016-08-22 06:49:21 PDT
Made a PR to W3C WPT tests at https://github.com/w3c/web-platform-tests/pull/3523 Same tests as in the patch with some minor style tweaks.
WebKit Commit Bot
Comment 5 2016-08-23 03:20:21 PDT
Comment on attachment 286571 [details] Patch Clearing flags on attachment: 286571 Committed r204795: <http://trac.webkit.org/changeset/204795>
WebKit Commit Bot
Comment 6 2016-08-23 03:20:26 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.