Bug 159140

Summary:

Add support for WebIDL setlike

Product:

WebKit

Reporter:

youenn fablet <youennf>

Component:

WebCore Misc.

Assignee:

youenn fablet <youennf>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

annulen, benjamin, buildbot, calvaris, cdumez, commit-queue, darin, esprehn+autocc, ews-watchlist, gyuyoung.kim, kondapallykalyan, mmaxfield, rniwa, ryuan.choi, sam, sergio, webkit-bug-importer, zalan

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

See Also:

https://bugs.webkit.org/show_bug.cgi?id=166916

Bug Depends on:

Bug Blocks:

159146, 204847

Attachments:

Description	Flags
Patch	none
Fixing style	none
WIP	none
Patch	none
Archive of layout-test-results from ews101 for mac-elcapitan	none
Archive of layout-test-results from ews107 for mac-elcapitan-wk2	none
Archive of layout-test-results from ews117 for mac-elcapitan	none
Archive of layout-test-results from ews126 for ios-simulator-wk2	none
Reduced patch to binding code	none
Patch	none
Patch	none

youenn fablet

Reported 2016-06-27 03:04:39 PDT

We should implement https://heycam.github.io/webidl/#idl-setlike and apply to FontFaceSet.idl

Attachments
Patch (84.58 KB, patch) 2016-06-27 04:03 PDT, youenn fablet	no flags	Details Formatted Diff Diff
Fixing style (84.58 KB, patch) 2016-06-27 05:11 PDT, youenn fablet	no flags	Details Formatted Diff Diff
WIP (106.92 KB, patch) 2017-02-02 08:16 PST, youenn fablet	no flags	Details Formatted Diff Diff
Patch (132.57 KB, patch) 2017-02-16 21:23 PST, youenn fablet	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews101 for mac-elcapitan (996.08 KB, application/zip) 2017-02-16 23:42 PST, Build Bot	no flags	Details
Archive of layout-test-results from ews107 for mac-elcapitan-wk2 (908.42 KB, application/zip) 2017-02-16 23:44 PST, Build Bot	no flags	Details
Archive of layout-test-results from ews117 for mac-elcapitan (1.71 MB, application/zip) 2017-02-16 23:50 PST, Build Bot	no flags	Details
Archive of layout-test-results from ews126 for ios-simulator-wk2 (781.45 KB, application/zip) 2017-02-16 23:54 PST, Build Bot	no flags	Details
Reduced patch to binding code (97.94 KB, patch) 2019-11-05 07:07 PST, youenn fablet	no flags	Details Formatted Diff Diff
Patch (116.86 KB, patch) 2019-11-19 00:10 PST, youenn fablet	no flags	Details Formatted Diff Diff
Patch (125.43 KB, patch) 2019-11-19 18:45 PST, youenn fablet	no flags	Details Formatted Diff Diff
Show Obsolete (10) View All Add attachment proposed patch, testcase, etc.

youenn fablet

Comment 1 2016-06-27 04:03:32 PDT

Created attachment 282117 [details] Patch

youenn fablet

Comment 2 2016-06-27 05:11:59 PDT

Created attachment 282121 [details] Fixing style

youenn fablet

Comment 3 2016-07-13 02:16:53 PDT

As part of this bug, we should ensure that binding generator dies for "iterable" interfaces that do not have indexed getters.

youenn fablet

Comment 4 2017-02-02 08:16:26 PST

Created attachment 300409 [details] WIP

youenn fablet

Comment 5 2017-02-02 08:16:43 PST

*** Bug 159146 has been marked as a duplicate of this bug. ***

youenn fablet

Comment 6 2017-02-16 21:23:04 PST

Created attachment 301878 [details] Patch

WebKit Commit Bot

Comment 7 2017-02-16 22:30:34 PST

Attachment 301878 [details] did not pass style-queue: ERROR: Source/WebCore/bindings/js/JSDOMSetLike.h:66: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/WebCore/bindings/js/JSDOMGuardedObject.h:60: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/WebCore/bindings/js/JSDOMGlobalObject.h:37: Code inside a namespace should not be indented. [whitespace/indent] [4] ERROR: Source/WebCore/bindings/js/JSDOMPromise.h:121: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] Total errors found: 4 in 31 files If any of these errors are false positives, please file a bug against check-webkit-style.

youenn fablet

Comment 8 2017-02-16 22:40:07 PST

Setlike part of the patch is working. Integration with FontFacetSet is not properly working since every time the backing font face set is updated, we should update the FontFacet set like object. Current iterator implementation enforces this by iterating through the backing font face set.

Build Bot

Comment 9 2017-02-16 23:42:08 PST

Comment on attachment 301878 [details] Patch Attachment 301878 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/3141693 New failing tests: fast/text/font-face-set-cssom.html fast/text/font-face-set-javascript.html

Build Bot

Comment 10 2017-02-16 23:42:13 PST

Created attachment 301891 [details] Archive of layout-test-results from ews101 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews101 Port: mac-elcapitan Platform: Mac OS X 10.11.6

Build Bot

Comment 11 2017-02-16 23:44:17 PST

Comment on attachment 301878 [details] Patch Attachment 301878 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/3141697 New failing tests: fast/text/font-face-set-cssom.html fast/text/font-face-set-javascript.html

Build Bot

Comment 12 2017-02-16 23:44:22 PST

Created attachment 301893 [details] Archive of layout-test-results from ews107 for mac-elcapitan-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews107 Port: mac-elcapitan-wk2 Platform: Mac OS X 10.11.6

Build Bot

Comment 13 2017-02-16 23:49:59 PST

Comment on attachment 301878 [details] Patch Attachment 301878 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/3141701 New failing tests: fast/text/font-face-set-cssom.html fast/text/font-face-set-javascript.html

Build Bot

Comment 14 2017-02-16 23:50:05 PST

Created attachment 301894 [details] Archive of layout-test-results from ews117 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews117 Port: mac-elcapitan Platform: Mac OS X 10.11.6

Build Bot

Comment 15 2017-02-16 23:54:01 PST

Comment on attachment 301878 [details] Patch Attachment 301878 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/3141703 New failing tests: fast/text/font-face-set-cssom.html fast/text/font-face-set-javascript.html

Build Bot

Comment 16 2017-02-16 23:54:07 PST

Created attachment 301895 [details] Archive of layout-test-results from ews126 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews126 Port: ios-simulator-wk2 Platform: Mac OS X 10.11.6

youenn fablet

Comment 17 2019-11-05 07:07:56 PST

Created attachment 382820 [details] Reduced patch to binding code

youenn fablet

Comment 18 2019-11-19 00:10:36 PST

Created attachment 383850 [details] Patch

youenn fablet

Comment 19 2019-11-19 18:45:57 PST

Created attachment 383933 [details] Patch

Darin Adler

Comment 20 2019-12-03 12:53:21 PST

Comment on attachment 383933 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=383933&action=review > Source/WebCore/bindings/scripts/IDLParser.pm:2108 > + # FIXME: Add support to forEach What's the status on this part?

youenn fablet

Comment 21 2019-12-04 03:21:48 PST

(In reply to Darin Adler from comment #20) > Comment on attachment 383933 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=383933&action=review > > > Source/WebCore/bindings/scripts/IDLParser.pm:2108 > > + # FIXME: Add support to forEach > > What's the status on this part? I'll add support as a follow-up

WebKit Commit Bot

Comment 22 2019-12-04 04:07:01 PST

Comment on attachment 383933 [details] Patch Clearing flags on attachment: 383933 Committed r253100: <https://trac.webkit.org/changeset/253100>

WebKit Commit Bot

Comment 23 2019-12-04 04:07:04 PST

All reviewed patches have been landed. Closing bug.

Radar WebKit Bug Importer

Comment 24 2019-12-04 04:08:20 PST

<rdar://problem/57620807>

Note You need to log in before you can comment on or make changes to this bug.