Bug 159149

Summary: Remove didFailAccessControlCheck ThreadableLoaderClient callback
Product: WebKit Reporter: youenn fablet <youennf>
Component: WebCore Misc.Assignee: youenn fablet <youennf>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, buildbot, cdumez, commit-queue, dbates, japhet, mkwst, rniwa
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=218457
Bug Depends on:    
Bug Blocks: 151937    
Attachments:
Description Flags
Patch
none
Archive of layout-test-results from ews104 for mac-yosemite-wk2
none
Archive of layout-test-results from ews123 for ios-simulator-wk2
none
Rebasing xhr test none

youenn fablet
Reported 2016-06-27 07:41:04 PDT
Following on bug 159085, we should remove didFailAccessControlCheck and use didFail instead.
Attachments
Patch (15.65 KB, patch)
2016-06-27 07:58 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from ews104 for mac-yosemite-wk2 (775.31 KB, application/zip)
2016-06-27 08:52 PDT, Build Bot 		no flags
Details
Archive of layout-test-results from ews123 for ios-simulator-wk2 (582.59 KB, application/zip)
2016-06-27 08:57 PDT, Build Bot 		no flags
Details
Rebasing xhr test (19.06 KB, patch)
2016-06-27 09:50 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
youenn fablet
Comment 1 2016-06-27 07:58:53 PDT
Created attachment 282132 [details] Patch
youenn fablet
Comment 2 2016-06-27 08:07:36 PDT
As a side note, it is not clear whether error messages should end with a '.'or not. Consistency would be good here.
Build Bot
Comment 3 2016-06-27 08:51:57 PDT
Comment on attachment 282132 [details] Patch Attachment 282132 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/1580083 New failing tests: imported/w3c/web-platform-tests/XMLHttpRequest/send-authentication-cors-setrequestheader-no-cred.htm
Build Bot
Comment 4 2016-06-27 08:52:01 PDT
Created attachment 282134 [details] Archive of layout-test-results from ews104 for mac-yosemite-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews104 Port: mac-yosemite-wk2 Platform: Mac OS X 10.10.5
Build Bot
Comment 5 2016-06-27 08:57:53 PDT
Comment on attachment 282132 [details] Patch Attachment 282132 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/1580084 New failing tests: imported/w3c/web-platform-tests/XMLHttpRequest/send-authentication-cors-setrequestheader-no-cred.htm
Build Bot
Comment 6 2016-06-27 08:57:56 PDT
Created attachment 282135 [details] Archive of layout-test-results from ews123 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews123 Port: ios-simulator-wk2 Platform: Mac OS X 10.11.4
youenn fablet
Comment 7 2016-06-27 09:50:01 PDT
Created attachment 282139 [details] Rebasing xhr test
WebKit Commit Bot
Comment 8 2016-06-27 23:09:25 PDT
Comment on attachment 282139 [details] Rebasing xhr test Clearing flags on attachment: 282139 Committed r202542: <http://trac.webkit.org/changeset/202542>
WebKit Commit Bot
Comment 9 2016-06-27 23:09:30 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.