Bug 159404

Summary: Remove CredentialRequest ResourceLoaderOptions
Product: WebKit Reporter: youenn fablet <youennf>
Component: WebCore Misc.Assignee: youenn fablet <youennf>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, commit-queue, dbates
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 151937    
Attachments:
Description Flags
Patch
none
Patch for landing none

youenn fablet
Reported 2016-07-04 04:15:36 PDT
CredentialRequest is only used by DocumentThreadableLoader to disable credential sending in case of cross-origin redirection. This is handled by FetchOptions::Credentials::SameOrigin.
Attachments
Patch (25.10 KB, patch)
2016-07-04 04:44 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch for landing (26.35 KB, patch)
2016-07-05 00:30 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
youenn fablet
Comment 1 2016-07-04 04:16:37 PDT
Note that ultimately, all credential-related ResourceLoaderOptions should probably be removed except for FetchOptions::Credentials.
youenn fablet
Comment 2 2016-07-04 04:44:09 PDT
Created attachment 282706 [details] Patch
youenn fablet
Comment 3 2016-07-05 00:30:48 PDT
Created attachment 282754 [details] Patch for landing
WebKit Commit Bot
Comment 4 2016-07-05 00:59:53 PDT
Comment on attachment 282754 [details] Patch for landing Clearing flags on attachment: 282754 Committed r202815: <http://trac.webkit.org/changeset/202815>
WebKit Commit Bot
Comment 5 2016-07-05 00:59:57 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.