Bug 159643

Summary:

MarkedBlocks should know that they can be used for more than JSCells

Product:

WebKit

Reporter:

Filip Pizlo <fpizlo>

Component:

JavaScriptCore

Assignee:

Filip Pizlo <fpizlo>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, ggaren

Priority:

Version:

WebKit Nightly Build

Hardware:

All

OS:

All

Bug Depends on:

Bug Blocks:

159644, 159658

Attachments:

Description	Flags
stuff	none
the carnage expands	none
more	none
OMG it compiles!	none
the patch	ggaren: review+
performance	none
rebased patch	none
patch for landing	none
patch for landing	none

Filip Pizlo

Reported 2016-07-11 13:31:10 PDT

Patch forthcoming.

Attachments
stuff (28.56 KB, patch) 2016-07-11 13:31 PDT, Filip Pizlo	no flags	Details Formatted Diff Diff
the carnage expands (45.05 KB, patch) 2016-07-11 15:01 PDT, Filip Pizlo	no flags	Details Formatted Diff Diff
more (55.83 KB, patch) 2016-07-11 17:14 PDT, Filip Pizlo	no flags	Details Formatted Diff Diff
OMG it compiles! (58.59 KB, patch) 2016-07-11 17:32 PDT, Filip Pizlo	no flags	Details Formatted Diff Diff
the patch (67.30 KB, patch) 2016-07-12 11:36 PDT, Filip Pizlo	ggaren: review+	Details Formatted Diff Diff
performance (78.65 KB, text/plain) 2016-07-12 12:52 PDT, Filip Pizlo	no flags	Details
rebased patch (63.11 KB, patch) 2016-07-12 12:55 PDT, Filip Pizlo	no flags	Details Formatted Diff Diff
patch for landing (63.11 KB, patch) 2016-07-18 13:01 PDT, Filip Pizlo	no flags	Details Formatted Diff Diff
patch for landing (63.33 KB, patch) 2016-07-18 13:52 PDT, Filip Pizlo	no flags	Details Formatted Diff Diff
Show Obsolete (7) View All Add attachment proposed patch, testcase, etc.

Filip Pizlo

Comment 1 2016-07-11 13:31:51 PDT

Created attachment 283338 [details] stuff

Filip Pizlo

Comment 2 2016-07-11 15:01:15 PDT

Created attachment 283349 [details] the carnage expands

Filip Pizlo

Comment 3 2016-07-11 17:14:10 PDT

Created attachment 283368 [details] more

Filip Pizlo

Comment 4 2016-07-11 17:32:06 PDT

Created attachment 283370 [details] OMG it compiles!

Filip Pizlo

Comment 5 2016-07-12 11:36:16 PDT

Created attachment 283434 [details] the patch

Geoffrey Garen

Comment 6 2016-07-12 11:40:04 PDT

Comment on attachment 283434 [details] the patch r=me

Filip Pizlo

Comment 7 2016-07-12 12:52:01 PDT

Created attachment 283441 [details] performance

Filip Pizlo

Comment 8 2016-07-12 12:55:18 PDT

Created attachment 283442 [details] rebased patch

WebKit Commit Bot

Comment 9 2016-07-12 12:57:19 PDT

Attachment 283442 [details] did not pass style-queue: ERROR: Source/JavaScriptCore/heap/MarkedSpace.cpp:52: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/JavaScriptCore/heap/MarkedSpace.cpp:62: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/JavaScriptCore/heap/MarkedSpace.cpp:71: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/JavaScriptCore/heap/MarkedSpace.cpp:82: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/JavaScriptCore/heap/MarkedSpace.cpp:113: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/JavaScriptCore/heap/MarkedSpace.cpp:126: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/JavaScriptCore/heap/MarkedSpace.cpp:153: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/JavaScriptCore/heap/MarkedSpace.cpp:162: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/JavaScriptCore/heap/MarkedSpace.cpp:209: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/JavaScriptCore/heap/MarkedSpace.cpp:236: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/JavaScriptCore/heap/MarkedSpace.cpp:244: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/JavaScriptCore/heap/MarkedSpace.cpp:272: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/JavaScriptCore/heap/MarkedSpace.h:208: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/JavaScriptCore/heap/MarkedSpace.h:218: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/JavaScriptCore/heap/MarkedAllocator.cpp:243: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/JavaScriptCore/heap/Heap.cpp:954: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/JavaScriptCore/heap/Heap.cpp:982: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/JavaScriptCore/heap/Heap.cpp:992: Place brace on its own line for function definitions. [whitespace/braces] [4] Total errors found: 18 in 22 files If any of these errors are false positives, please file a bug against check-webkit-style.

Filip Pizlo

Comment 10 2016-07-18 13:01:54 PDT

Created attachment 283918 [details] patch for landing

WebKit Commit Bot

Comment 11 2016-07-18 13:03:46 PDT

Attachment 283918 [details] did not pass style-queue: ERROR: Source/JavaScriptCore/heap/MarkedSpace.cpp:52: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/JavaScriptCore/heap/MarkedSpace.cpp:62: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/JavaScriptCore/heap/MarkedSpace.cpp:71: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/JavaScriptCore/heap/MarkedSpace.cpp:82: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/JavaScriptCore/heap/MarkedSpace.cpp:113: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/JavaScriptCore/heap/MarkedSpace.cpp:126: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/JavaScriptCore/heap/MarkedSpace.cpp:153: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/JavaScriptCore/heap/MarkedSpace.cpp:162: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/JavaScriptCore/heap/MarkedSpace.cpp:209: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/JavaScriptCore/heap/MarkedSpace.cpp:236: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/JavaScriptCore/heap/MarkedSpace.cpp:244: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/JavaScriptCore/heap/MarkedSpace.cpp:272: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/JavaScriptCore/heap/MarkedSpace.h:208: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/JavaScriptCore/heap/MarkedSpace.h:218: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/JavaScriptCore/heap/MarkedAllocator.cpp:243: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/JavaScriptCore/heap/Heap.cpp:954: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/JavaScriptCore/heap/Heap.cpp:982: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/JavaScriptCore/heap/Heap.cpp:992: Place brace on its own line for function definitions. [whitespace/braces] [4] Total errors found: 18 in 22 files If any of these errors are false positives, please file a bug against check-webkit-style.

Filip Pizlo

Comment 12 2016-07-18 13:52:09 PDT

Created attachment 283927 [details] patch for landing

WebKit Commit Bot

Comment 13 2016-07-18 13:54:33 PDT

Attachment 283927 [details] did not pass style-queue: ERROR: Source/JavaScriptCore/heap/MarkedSpace.cpp:52: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/JavaScriptCore/heap/MarkedSpace.cpp:62: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/JavaScriptCore/heap/MarkedSpace.cpp:71: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/JavaScriptCore/heap/MarkedSpace.cpp:82: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/JavaScriptCore/heap/MarkedSpace.cpp:113: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/JavaScriptCore/heap/MarkedSpace.cpp:126: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/JavaScriptCore/heap/MarkedSpace.cpp:153: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/JavaScriptCore/heap/MarkedSpace.cpp:162: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/JavaScriptCore/heap/MarkedSpace.cpp:209: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/JavaScriptCore/heap/MarkedSpace.cpp:236: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/JavaScriptCore/heap/MarkedSpace.cpp:244: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/JavaScriptCore/heap/MarkedSpace.cpp:272: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/JavaScriptCore/heap/MarkedSpace.h:208: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/JavaScriptCore/heap/MarkedSpace.h:218: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/JavaScriptCore/heap/MarkedAllocator.cpp:243: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/JavaScriptCore/heap/Heap.cpp:954: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/JavaScriptCore/heap/Heap.cpp:982: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/JavaScriptCore/heap/Heap.cpp:992: Place brace on its own line for function definitions. [whitespace/braces] [4] Total errors found: 18 in 22 files If any of these errors are false positives, please file a bug against check-webkit-style.

Filip Pizlo

Comment 14 2016-07-18 14:35:53 PDT

Landed in https://trac.webkit.org/changeset/203375

Note You need to log in before you can comment on or make changes to this bug.