Bug 160919

Summary: Add support for ShadowRoot.mode attribute
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: DOMAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, commit-queue, rniwa
Priority: P2 Keywords: WebExposed
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
URL: https://dom.spec.whatwg.org/#interface-shadowroot
Bug Depends on:    
Bug Blocks: 148695    
Attachments:
Description Flags
Patch
none
Patch none

Chris Dumez
Reported 2016-08-16 16:14:54 PDT
Add support for ShadowRoot.mode attribute: - https://dom.spec.whatwg.org/#interface-shadowroot
Attachments
Patch (21.83 KB, patch)
2016-08-16 16:26 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (21.89 KB, patch)
2016-08-16 16:56 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2016-08-16 16:26:23 PDT
Created attachment 286230 [details] Patch
Ryosuke Niwa
Comment 2 2016-08-16 16:54:45 PDT
Comment on attachment 286230 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=286230&action=review > Source/WebCore/dom/ShadowRoot.idl:37 > +enum ShadowRootMode { "user-agent", "closed", "open" }; Maybe we should add a comment that "user-agent" is a WebKit extension that should never be exposed to the Web?
Chris Dumez
Comment 3 2016-08-16 16:56:42 PDT
Created attachment 286234 [details] Patch
WebKit Commit Bot
Comment 4 2016-08-16 17:27:12 PDT
Comment on attachment 286234 [details] Patch Clearing flags on attachment: 286234 Committed r204543: <http://trac.webkit.org/changeset/204543>
WebKit Commit Bot
Comment 5 2016-08-16 17:27:17 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.