Bug 163770

Summary: Wasm should support floating point operations.
Product: WebKit Reporter: Keith Miller <keith_miller>
Component: JavaScriptCoreAssignee: Keith Miller <keith_miller>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, mark.lam, msaboff, saam, ysuzuki
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 161728    
Attachments:
Description Flags
Patch
none
Patch for landing none

Keith Miller
Reported 2016-10-20 18:07:20 PDT
When we do this we will need a way to get access a 32-bit FPR argument register.
Attachments
Patch (30.10 KB, patch)
2016-10-24 10:57 PDT, Keith Miller 		no flags
DetailsFormatted DiffDiff
Patch for landing (30.52 KB, patch)
2016-10-24 12:12 PDT, Keith Miller 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Keith Miller
Comment 1 2016-10-24 10:57:12 PDT
Created attachment 292629 [details] Patch
Keith Miller
Comment 2 2016-10-24 11:01:54 PDT
Comment on attachment 292629 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=292629&action=review > Source/JavaScriptCore/ChangeLog:7 > + This should also say: This patch also fixes a bug in the call opcode where the arguments would be reversed.
Mark Lam
Comment 3 2016-10-24 11:10:39 PDT
Comment on attachment 292629 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=292629&action=review > Source/JavaScriptCore/wasm/WasmCallingConvention.h:137 > - if (returnType == B3::Void) > - return nullptr; > - > - patchpoint->resultConstraint = B3::ValueRep::reg(GPRInfo::returnValueGPR); > + switch (returnType) { > + case B3::Void: > + break; This is a difference in behavior not related to floating point. Previously, you return a nullptr for a Void returnType. Now, you return a non-null patchpoint pointer. Is this intentional?
Michael Saboff
Comment 4 2016-10-24 11:10:59 PDT
Comment on attachment 292629 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=292629&action=review r=me >> Source/JavaScriptCore/ChangeLog:7 >> + > > This should also say: This patch also fixes a bug in the call opcode where the arguments would be reversed. Please add some text as to what you did to enable FP operations.
Yusuke Suzuki
Comment 5 2016-10-24 11:13:06 PDT
(In reply to comment #2) > Comment on attachment 292629 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=292629&action=review > > > Source/JavaScriptCore/ChangeLog:7 > > + > > This should also say: This patch also fixes a bug in the call opcode where > the arguments would be reversed. Oops, thanks. I was planning to comment "Is it ok changing the order of the args?" :)
Keith Miller
Comment 6 2016-10-24 12:12:20 PDT
Created attachment 292641 [details] Patch for landing
WebKit Commit Bot
Comment 7 2016-10-24 14:47:23 PDT
Comment on attachment 292641 [details] Patch for landing Clearing flags on attachment: 292641 Committed r207781: <http://trac.webkit.org/changeset/207781>
WebKit Commit Bot
Comment 8 2016-10-24 14:47:27 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.